High rate of un-enriched network errors

[twschiller]

Investigation:

• Related to how axios-fetch-adapter captures/rethrows errors? https://github.com/vespaiach/axios-fetch-adapter/blob/main/src/getResponse.js

Example occurrences:

• https://rollbar.com/pixiebrix/pixiebrix/items/2546/occurrences/220906627426/

[fregante]

This is already taken care of by #3014

It's waiting for your review

[twschiller]

This is already taken care by #3014

Could you confirm that it works (and that the data flows correctly to Rollbar). I confirmed that you have the necessary permissions in Rollbar to confirm

Also, as part of this issue I want to double-check that the error handling in the axios-fetch-adapter library is correct. Were you able to confirm as part of the PR?

[fregante]

• Related to how axios-fetch-adapter captures/rethrows errors?

That doesn't seem to match the timeline since the adapter was added in December (and it hasn't been updated since) while these error spiked in early March:

• Use fetch inside Axios in the background #2108

Could you confirm that it works

I have not tested the PR yet because it's incomplete: I wanted to make sure it was a sensible idea before I spent any more time on it. But I suppose I'll proceed now.

and that the data flows correctly to Rollbar

Do I have to do anything specific to send errors to Rollbar from my local version? Or do I use reportError as usual and wait for it to appear on Rollbar.com?

Also, as part of this issue I want to double-check that the error handling in the axios-fetch-adapter library is correct. Were you able to confirm as part of the PR?

I wonder if fetch leaks those Network errors (they look like what appears in the console) but then again the timeline doesn't match. I will try with and without the new adapter.

[twschiller]

That doesn't seem to match the timeline since the adapter was added in December (and it hasn't been updated since) while these error spiked in early March

I suspect the increase is related to: 1) increase in enterprise users, 2) one of our enterprise clients moving back into the office where one of their VPNs/firewalls may be blocking some requests

We're working with their team to try to get the network call information from the background page

Also, as part of this issue I want to double-check that the error handling in the axios-fetch-adapter library is correct.

My hypothesis is not that the adapter is causing the requests to fail. I suspect the problem is that the adapter might not be forwarding all of the error information. I'd be curious what details are actually in that error (or if there's a more informative error in practice)

Here is the createError method that is called: https://github.com/vespaiach/axios-fetch-adapter/blob/main/index.js#L51

I suspect that catch block in getResponse might need to pass along additional details from the fetch error somehow?