Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buttons] Update CSS for new markup #119

Closed
madalingorbanescu opened this issue May 11, 2020 · 0 comments
Closed

[Buttons] Update CSS for new markup #119

madalingorbanescu opened this issue May 11, 2020 · 0 comments
Labels

Comments

@madalingorbanescu
Copy link
Contributor

In ultimele versiuni ale plugin-ului de Gutenberg au aparut niste modificari in markupul butoanelor, dar ulterior au facut revert, pentru ca modificarea de markup a stricat stilurile butoanelor in mai multe teme, inclusiv Rosa2.

Aici este PR-ul in care s-a facut revert-ul si tot in acest PR, developer-ul a spus:
I'd still encourage theme authors to update their styles to only rely on wp-block-button__link without requiring the presence of a wp-button parent or not which would make the styles work regardless of the chosen markup in the end.

Cred ca momentan putem duplica codul pentru butoane, ca sa functioneze stilurile atat pe mark-up-ul vechi, cat si pe cel actualizat, iar dupa ce stabileste exact mark-up-ul, sa facem remove garbage.

CC @razwan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant