Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bosh trap refactor/security fix #11

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Bosh trap refactor/security fix #11

merged 2 commits into from
Aug 29, 2019

Conversation

Houlistonm
Copy link
Contributor

Current implementation of multiple traps

trap 'rm -f ${ssh_key_path}' EXIT`
trap 'rm -f ${bosh_ca_path}' EXIT`

has the effect of the second trap replacing the first and allowing files to accumulate in /tmp.

Refactored so a single trap will remove both files on exit.

@edwardecook
Copy link
Contributor

Same as #10 looks good but need to enable Pivotal CLA bot.

@pivotal-issuemaster
Copy link

@Houlistonm Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@Houlistonm Thank you for signing the Contributor License Agreement!

@Houlistonm
Copy link
Contributor Author

Houlistonm commented Aug 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants