Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin should find tests without a MethodSource #39

Open
christophsturm opened this issue Nov 14, 2019 · 0 comments
Open

plugin should find tests without a MethodSource #39

christophsturm opened this issue Nov 14, 2019 · 0 comments

Comments

@christophsturm
Copy link

christophsturm commented Nov 14, 2019

I'm using pitest with minutest (https://github.com/dmcg/minutest), and in its latest version minutest does not set a MethodSource.
looking at the plugin source it seems that the method source is only used for test filtering. so my suggestion would be to check for a method source only when includedTests is not empty.

i think the fix would to do this check https://github.com/pitest/pitest-junit5-plugin/blob/master/src/main/java/org/pitest/junit5/JUnit5TestUnitFinder.java#L89
before the isPresent check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant