Don't throw on nil :__html value #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman01la
reviewed
Mar 31, 2023
| #?(:clj | ||
| (deftest nil-dangerously-set-inner-html | ||
| (is (= (render ($ username {:username nil})) "<p></p>")) | ||
| (is (thrown? Exception (render ($ bad-username {:foo 1})))))) |
There was a problem hiding this comment.
shouldn't this test fail since the rendering code checks for presence of a key?
this is also how React SSR works, they only check for presence of a key https://codesandbox.io/s/suspicious-gould-f3jxg9?file=/src/index.js
There was a problem hiding this comment.
Which test exactly? The first or second is check?
There was a problem hiding this comment.
uh, sorry, I miss read the change, looks good! :D
There was a problem hiding this comment.
you made me super confused :D had to re-read the code a couple times!
roman01la
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #101
This is how React handles
nilfrom what I can seeAdded tests cases for both paths!