Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect deps linting when local var shadows JS global #106

Closed
roman01la opened this issue Apr 21, 2023 · 0 comments
Closed

incorrect deps linting when local var shadows JS global #106

roman01la opened this issue Apr 21, 2023 · 0 comments
Labels
bug Something isn't working linter

Comments

@roman01la
Copy link
Collaborator

Requires shadow-cljs 2.20.16+

Given this code

(defui test-hook-deps [{:keys [x]}]
  (let [document 1]
    (uix.core/use-effect
      (fn []
        (println x document))
      [x])))

UIx's linter will not complain about document being not included in hook's deps vector
@roman01la roman01la added bug Something isn't working linter labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linter
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roman01la