-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RandomState (deprecated from numpy) to default_rng (Generator) #3220
Open
SagarDollin
wants to merge
10
commits into
piskvorky:develop
Choose a base branch
from
SagarDollin:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 28, 2021
-
Updated RandomState (deprecated from numpy) to default_rng (Generator)
This is regarding the issue piskvorky#2782 . Here are the benchmarks of before and after updating: Before Update After Update Poincare Ran 42 tests in 0.418s Ran 42 tests in 0.417s test_lda Ran 48 tests in 223.845s Ran 48 tests in 225.561s utils Ran 24 tests in 0.007s Ran 24 tests in 0.007s test_matutils Ran 18 tests in 0.071s Ran 18 tests in 0.070s word2vec Ran 79 tests in 58.149s Ran 79 tests in 57.950s I don't find a big difference in time taken. However I feel it is good to be updated along with numpy.
Configuration menu - View commit details
-
Copy full SHA for 8443280 - Browse repository at this point
Copy the full SHA 8443280View commit details -
For some reason the test_word2vec's function test_compute_training_loss() fails when we use default_rng instead of RandomState, therefore reverting the changes only for word2vec
Configuration menu - View commit details
-
Copy full SHA for 82634c9 - Browse repository at this point
Copy the full SHA 82634c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bbccb0 - Browse repository at this point
Copy the full SHA 4bbccb0View commit details
Commits on Aug 29, 2021
-
Resolved some dependencies related to RandomState
resolved some dependencies on RandomState. randint is a method of RandomState , however not supported in Generator. For Generator we use integers. Also fixed a small error about inferred variable (related to index error)
Configuration menu - View commit details
-
Copy full SHA for 78f1b78 - Browse repository at this point
Copy the full SHA 78f1b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc67c5f - Browse repository at this point
Copy the full SHA dc67c5fView commit details
Commits on Aug 30, 2021
-
fixing test_failures that were caused due to a different intitializat…
…ion of random function Since we are using a totally different random Generator which is not RandomState, therefore there will be differences in intilizations of weights or any random initialization, than that of last versions. The hardcoded values in tests will fail therfore. I had to change these hardcoded values to the new resluts we get. Example in test_similarity_mertics , I added a delta of 5.0e-06 to incorporate small changes. Note in test_ensemblelda i had to remove 2 tests as these two test were comparing previously saved model with new model , which will be not same as we are using different Random Generator. I'm not an expert in all the models therefore a review for the changes in test files is required.
Configuration menu - View commit details
-
Copy full SHA for 0789a81 - Browse repository at this point
Copy the full SHA 0789a81View commit details -
Configuration menu - View commit details
-
Copy full SHA for f077516 - Browse repository at this point
Copy the full SHA f077516View commit details
Commits on Sep 2, 2021
-
fixed falke8 related styling errors
Sorry for the inconvenience . Pushing after fixing flake8 related styling of code issues
Configuration menu - View commit details
-
Copy full SHA for f3e54cd - Browse repository at this point
Copy the full SHA f3e54cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab3c340 - Browse repository at this point
Copy the full SHA ab3c340View commit details
Commits on Mar 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a6e855d - Browse repository at this point
Copy the full SHA a6e855dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.