Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package #39

Closed
jehna opened this issue Nov 13, 2023 · 10 comments
Closed

NPM package #39

jehna opened this issue Nov 13, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@jehna
Copy link

jehna commented Nov 13, 2023

It seems that this project does not yet have a functioning npm package; the one at npm seems to be an empty placeholder.

I'm the developer of https://github.vom/jehna/humanify and I'd like to use Wakaru as a part of Humanify instead of webcrack (see jehna/humanify#3).

@pionxzh
Copy link
Owner

pionxzh commented Nov 13, 2023

Hi, thanks for interesting in this project. The reason why there is no NPM package at first is because I thought the API would be unstable under heavy development. But I think now it shall be ok to provide a 0.x release.

May I confirm the part you need? unpack or unminify?

@pionxzh pionxzh added the enhancement New feature or request label Nov 13, 2023
@pionxzh
Copy link
Owner

pionxzh commented Nov 13, 2023

OK, I checked your repo, it is the unpacking part. I haven't checked the detail of webcrack to see which tool have better support coverage. You will need to do the test by yourself at the moment. Another strategy is choosing one tool as the fallback when no module is detected.

And you can also run unminify before sending it to GPT to reduce the syntax noise.

@0xdevalias
Copy link

May I confirm the part you need? unpack or unminify?

Personally I would love to see both published/available.

But I think now it shall be ok to provide a 0.x release.

I would personally be happy with 0.x releases with unstable API's, even if they change dramatically.

@0xdevalias
Copy link

Looks like some progress happening on this one :)

  • 2c281bc: feat: build package
  • 81d2c28: chore: add .release-please-manifest.json

@pionxzh
Copy link
Owner

pionxzh commented Nov 19, 2023

NPM package has been released. You can check the README for more information.

@0xdevalias
Copy link

@pionxzh Curious, would you be open to publishing @wakaru/ast-utils / etc as well?

@pionxzh
Copy link
Owner

pionxzh commented Dec 1, 2023

@0xdevalias Hmm it's intended to be just an internal dependency that API might change a lot at any time eh. I would suggest anyone who wants to use it can simply copy-paste.

@0xdevalias
Copy link

it's intended to be just an internal dependency

@pionxzh Makes sense.

that API might change a lot at any time eh

@pionxzh That makes sense. Though that was also theoretically the reason for not publishing unminify/etc as well yeah? But you ended up deciding that given it was a 0.x release that breaking changes weren't so much of an issue.

I would suggest anyone who wants to use it can simply copy-paste.

@pionxzh nods, that's fair enough.

@pionxzh
Copy link
Owner

pionxzh commented Dec 1, 2023

unminify is okay for me as the public interface shall be stable. But utils will really have some massive refactoring. So ya, no plan to publish them for now.

@0xdevalias
Copy link

So ya, no plan to publish them for now.

@pionxzh No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants