From 6c8c218dae25dfe4642536577b6b7cee55eda5c2 Mon Sep 17 00:00:00 2001 From: Seun Date: Mon, 20 Nov 2023 15:28:29 -0800 Subject: [PATCH] fix to incorrect error message when wrong refresh token is passed in --- pinterest/utils/refresh_access_token.py | 3 +- tests/src/pinterest/client/client_test.py | 35 +++++++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/pinterest/utils/refresh_access_token.py b/pinterest/utils/refresh_access_token.py index 9b313d6..252a1a9 100644 --- a/pinterest/utils/refresh_access_token.py +++ b/pinterest/utils/refresh_access_token.py @@ -50,7 +50,8 @@ def get_new_access_token( body="Authentication error. " + "Kindly check if the following variables are correct: [PINTEREST_ACCESS_TOKEN] or " + "[PINTEREST_APP_ID, PINTEREST_APP_SECRET, PINTEREST_REFRESH_ACCESS_TOKEN]. " + - f"Response from server: {response.body}" + f"Response from server: {response.data}", + http_resp=response ) if response.status != 200: raise SdkException(http_resp=response) diff --git a/tests/src/pinterest/client/client_test.py b/tests/src/pinterest/client/client_test.py index 49e7859..bc80563 100644 --- a/tests/src/pinterest/client/client_test.py +++ b/tests/src/pinterest/client/client_test.py @@ -52,3 +52,38 @@ def test_set_default_refresh_token(self, load_dotenv_mock): self.assertEqual(refresh_token, PINTEREST_REFRESH_ACCESS_TOKEN) self.assertEqual(app_id, PINTEREST_APP_ID) self.assertEqual(app_secret, PINTEREST_APP_SECRET) + + @mock.patch.dict( + os.environ, + { + "PINTEREST_APP_ID": "test_app_id", + "PINTEREST_APP_SECRET": "test_app_secret", + }, + clear=True + ) + @patch('dotenv.load_dotenv') + def test_set_bad_refresh_token(self, load_dotenv_mock): + load_dotenv_mock.return_value = None + refresh_token = 'refresh_token' + app_id = '12345' + app_secret = '123456asdfg' + + from pinterest.config import PINTEREST_REFRESH_ACCESS_TOKEN + from pinterest.config import PINTEREST_APP_ID + from pinterest.config import PINTEREST_APP_SECRET + self.assertNotEqual(refresh_token, PINTEREST_REFRESH_ACCESS_TOKEN) + self.assertNotEqual(app_id, PINTEREST_APP_ID) + self.assertNotEqual(app_secret, PINTEREST_APP_SECRET) + + PinterestSDKClient._get_access_token( + refresh_token=refresh_token, + app_id=app_id, + app_secret=app_secret + ) + + from pinterest.config import PINTEREST_REFRESH_ACCESS_TOKEN + from pinterest.config import PINTEREST_APP_ID + from pinterest.config import PINTEREST_APP_SECRET + self.assertEqual(refresh_token, PINTEREST_REFRESH_ACCESS_TOKEN) + self.assertEqual(app_id, PINTEREST_APP_ID) + self.assertEqual(app_secret, PINTEREST_APP_SECRET)