Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiCDC should respect cgroup limits #1798

Closed
1 of 2 tasks
overvenus opened this issue May 19, 2021 · 3 comments
Closed
1 of 2 tasks

TiCDC should respect cgroup limits #1798

overvenus opened this issue May 19, 2021 · 3 comments
Assignees
@overvenus
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

overvenus commented May 19, 2021 •
edited
Loading

Bug Report

  1. What did you do? If possible, provide a recipe for reproducing the error.

TiCDC should respects cgroup limits on Linux:

Otherwise, TiCDC may be misconfigured and cause OOM or other issues,

  1. What did you expect to see?

N/A

  1. What did you see instead?

N/A

  1. Versions of the cluster

master, v4.0.12 and v5.0.1
@overvenus overvenus added the type/bug The issue is confirmed as a bug. label May 19, 2021
@overvenus overvenus mentioned this issue Nov 12, 2021
Merged
@overvenus overvenus assigned zhaoxinyu and unassigned ben1009 Nov 12, 2021
@overvenus
Copy link
Member Author

For the second task, we can port TiKV cgroup detection https://github.com/tikv/tikv/blob/7b677d60ab3b60b3ef4750da09718ba8114060ed/components/tikv_util/src/sys/cgroup.rs

This was referenced Nov 12, 2021
Merged
Merged
Merged
Merged
Merged
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Dec 6, 2021
@overvenus overvenus mentioned this issue Jan 13, 2022
Merged
14 tasks
@nongfushanquan
Copy link
Contributor

/unassign @zhaoxinyu
/assign @overvenus

@ti-chi-bot ti-chi-bot assigned overvenus and unassigned zhaoxinyu Aug 8, 2022
@amyangfei
Copy link
Contributor

Task-2 is closed by #8589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overvenus overvenus

Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@amyangfei @ben1009 @overvenus @zhaoxinyu @AkiraXie @Tammyxia @nongfushanquan