Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid useless transform operations when block's row count is 0 #9711

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Avoid useless transform operations when block's row count is 0 #9711

merged 3 commits into from
Dec 11, 2024
+19 −0

Conversation

gengliqi
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

This change may cause an issue that a sink does not get any block after execution. Hence, some tests failed.
So I change the columnsEqual to make the empty-column block equal to the empty-row block.

Avoid useless `tranform` operations when block's row count is 0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
u
f50be1a 
Signed-off-by: gengliqi <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
windtalker
windtalker approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2024
@Lloyd-Pottiger
Copy link
Contributor

tranform --> transform?

@gengliqi gengliqi changed the title Avoid useless tranform operations when block's row count is 0 Avoid useless transform operations when block's row count is 0 Dec 11, 2024
yibin87
yibin87 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 00:22:49.782817499 +0000 UTC m=+397959.871620026: ☑️ agreed by windtalker.
  • 2024-12-11 07:42:51.921539141 +0000 UTC m=+424362.010341685: ☑️ agreed by yibin87.

@gengliqi
Copy link
Contributor Author

/run-all-tests

@gengliqi
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c576926 into pingcap:master Dec 11, 2024
5 checks passed
@gengliqi gengliqi deleted the update-transform branch December 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengliqi @Lloyd-Pottiger @windtalker @yibin87