Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Enable vector search fullstack tests #9501

Merged
merged 9 commits into from
Oct 12, 2024
Merged

tests: Enable vector search fullstack tests #9501

merged 9 commits into from
Oct 12, 2024

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9032

Problem Summary:

The feature branch is merged into tidb/tiflash master branch

What is changed and how it works?

Enable fullstack tests on tiflash CI

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@JaySon-Huang JaySon-Huang changed the title tests: Enable vector search tests tests: Enable vector search fullstack tests Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-test

@JaySon-Huang JaySon-Huang changed the title tests: Enable vector search fullstack tests [DNM] tests: Enable vector search fullstack tests Oct 9, 2024
@JaySon-Huang JaySon-Huang force-pushed the vector_tests branch 2 times, most recently from 6646aa3 to 0e30044 Compare October 9, 2024 13:28
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024
@JaySon-Huang JaySon-Huang force-pushed the vector_tests branch 2 times, most recently from 239a09b to b9b65ba Compare October 10, 2024 04:01
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 12, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 12, 2024
@JaySon-Huang JaySon-Huang changed the title [DNM] tests: Enable vector search fullstack tests tests: Enable vector search fullstack tests Oct 12, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-test

CalvinNeo
CalvinNeo approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 08:32:02.805085646 +0000 UTC m=+87119.953995478: ☑️ agreed by Lloyd-Pottiger.
  • 2024-10-12 09:54:19.541612873 +0000 UTC m=+92056.690522705: ☑️ agreed by CalvinNeo.

@JaySon-Huang
Copy link
Contributor Author

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 76a4cd5 into pingcap:master Oct 12, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the vector_tests branch October 14, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @CalvinNeo @Lloyd-Pottiger