tests: fix build on m1 macbook && re-enable clang-tidy checks #9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
JaySon-Huang
requested review from
Lloyd-Pottiger,
zanmato1984 and
JinheLin
Lloyd-Pottiger
approved these changes
Sep 30, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/hold I will push a commit to fix arm build later |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Lloyd-Pottiger <[email protected]>
ti-chi-bot
bot
added
size/S
Signed-off-by: Lloyd-Pottiger <[email protected]>
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
JinheLin
approved these changes
Sep 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
changed the title
JaySon-Huang
commented
Sep 30, 2024
| @@ -34,7 +39,9 @@ | |||
| #pragma clang diagnostic push | |||
| #pragma clang diagnostic ignored "-Wpass-failed" | |||
|
|
|||
| #if !defined(__APPLE__) | |||
| #include <type_traits> | |||
There was a problem hiding this comment.
can not build without this include
FAILED: dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o
/usr/local/bin/ccache /usr/local/bin/clang++ -DFIU_ENABLE -DSERVERLESS_PROXY=0 -DTIFLASH_COMPILER_VPCLMULQDQ_SUPPORT=1 -DTIFLASH_ENABLE_AVX512_SUPPORT=1 -DTIFLASH_ENABLE_AVX_SUPPORT=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/fp16/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/simsimd/include -isystem /home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/fmtlib-cmake/../fmtlib/include -Wthread-safety -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fno-omit-frame-pointer -Wall -Wno-unused-command-line-argument -Wnon-virtual-dtor -stdlib=libc++ -Wextra -Werror -O0 -fverbose-asm -fno-inline -D_LIBCPP_DEBUG=0 -std=gnu++2b -MD -MT dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o -MF dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o.d -o dbms/CMakeFiles/tiflash_vector_search.dir/src/VectorSearch/SIMDFeatures.cpp.o -c /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/SIMDFeatures.cpp
In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/SIMDFeatures.cpp:16:
In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/VectorSearch/USearch.h:42:
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:54: error: 'scalar_at' does not refer to a value
362 | if (!std::is_trivially_default_constructible<scalar_at>::value)
| ^
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:355:20: note: declared here
355 | template <typename scalar_at, typename allocator_at = std::allocator<scalar_at>> class buffer_gt {
| ^
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:19: error: no member named 'is_trivially_default_constructible' in namespace 'std'
362 | if (!std::is_trivially_default_constructible<scalar_at>::value)
| ~~~~~^
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/usearch/include/usearch/index.hpp:362:64: error: no member named 'value' in the global namespace; did you mean 'std::money_base::value'?
362 | if (!std::is_trivially_default_constructible<scalar_at>::value)
| ^~
/usr/local/bin/../include/c++/v1/locale:2573:43: note: 'std::money_base::value' declared here
2573 | enum part {none, space, symbol, sign, value};
|
There was a problem hiding this comment.
Interestingly I cannot build in MacOS if type_traits is not included as well.
There was a problem hiding this comment.
fix it in this PR: #9492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
clang-tidy is temporary disable to merge the feature branch
#9486 (comment)
What is changed and how it works?
re-enable the clang-tidy checks
Check List
Tests
Side effects
Documentation
Release note