-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Adapt with the latest vector index definition #9471
ddl: Adapt with the latest vector index definition #9471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zimulala: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL @zanmato1984 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, Lloyd-Pottiger, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
The "kind" field is removed from the tidb vector index definition
https://github.com/zimulala/tidb/blob/bce9dabc8c7712b98ca4f9cd90beca89a1d62ca8/pkg/meta/model/index.go#L36-L41
What is changed and how it works?
Removing the deadcode will make lots of test cases changes and introduce conflict when cherry-pick other PRs. This PR just do some small adaption to make things work as expected, the deadcode will be removed in later PRs
Check List
Tests
Side effects
Documentation
Release note