-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: long term cache for integer-like PK column in memory #9445
storage: long term cache for integer-like PK column in memory #9445
Conversation
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
.dmfile_id = dmf_id, | ||
.column_id = column_id, | ||
}; | ||
auto [result, _] = cache.getOrSet(key, [&load_fn] { return std::make_shared<IColumn::Ptr>(load_fn()); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, so it is supported now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Lloyd-Pottiger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, CalvinNeo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@Lloyd-Pottiger: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
5a41ce2
into
pingcap:feature/vector-index
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
Optimize for VectorDBBench.
ColumnArray::insertManyDefaults
. It is a critical path used in Vector Search, because Vector Search will return sparse results. (TODO: Use ColumnSparse is better)String block_filter_value;
, which costs time.BitmapFilter.get()
takes time. So this PR totally drops it.DMFileWithVectorIndexBlockInputStream
now builds the return filter directly from the result rows.Benchmark (VectorDBBench, Cohere 1M vectors, 768 dimensions):
Before this PR @ Macbook M1 Pro: 180QPS @ 30 concurrency
After this PR @ Macbook M1 Pro: 250QPS @ 30 concurrency
Check List
Tests
Side effects
Documentation
Release note