-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix duplicate symbol error of string.h #9366
Conversation
Signed-off-by: Calvin Neo <[email protected]>
This reverts commit 27c14c0.
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Only some of the rarely used functions are marked as inline and cannot be overridden. How about using approaches like https://github.com/tidbcloud/tiflash-cse/pull/245/files#diff-0d98be940370fadc881e27b4abc31168c77c6f65a03a3ec365ef3dd131c1b46a and https://github.com/tidbcloud/tiflash-cse/pull/248/files? |
Yes, you are right. I have fixed according to cse. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@CalvinNeo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #9367
Problem Summary: Compilation fails on RockyLinux 8 arm64 arch as the issue show
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note