Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix duplicate symbol error of string.h #9366

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Aug 26, 2024

What problem does this PR solve?

Issue Number: close #9367

Problem Summary: Compilation fails on RockyLinux 8 arm64 arch as the issue show

What is changed and how it works?

Fix compilation fails on RockyLinux 8 arm64 arch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

a
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
@CalvinNeo CalvinNeo changed the title DNM Fix duplicate symbol error of string.h Aug 26, 2024
@JaySon-Huang JaySon-Huang changed the title Fix duplicate symbol error of string.h build: Fix duplicate symbol error of string.h Aug 27, 2024
This reverts commit 27c14c0.
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2024
@CalvinNeo
Copy link
Member Author

f
Signed-off-by: Calvin Neo <[email protected]>
@breezewish
Copy link
Member

Only some of the rarely used functions are marked as inline and cannot be overridden. How about using approaches like https://github.com/tidbcloud/tiflash-cse/pull/245/files#diff-0d98be940370fadc881e27b4abc31168c77c6f65a03a3ec365ef3dd131c1b46a and https://github.com/tidbcloud/tiflash-cse/pull/248/files?

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
@CalvinNeo
Copy link
Member Author

Only some of the rarely used functions are marked as inline and cannot be overridden. How about using approaches like https://github.com/tidbcloud/tiflash-cse/pull/245/files#diff-0d98be940370fadc881e27b4abc31168c77c6f65a03a3ec365ef3dd131c1b46a and https://github.com/tidbcloud/tiflash-cse/pull/248/files?

Yes, you are right. I have fixed according to cse.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 06:33:12.506913012 +0000 UTC m=+851987.641363179: ☑️ agreed by breezewish.
  • 2024-08-27 06:43:40.230867716 +0000 UTC m=+852615.365317837: ☑️ agreed by Lloyd-Pottiger.

Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 9afd0b2 into pingcap:master Aug 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails on RockyLinux 8 arm64 arch
3 participants