Storages: Skip filtering for filter column

[JinheLin]

What problem does this PR solve?

Issue Number: close #9348, ref #9103

Problem Summary:

If Min-Max index returns RSResult::All, we will create a EMPTY filter column to make some checks on block structure happy.

tiflash/dbms/src/DataStreams/FilterTransformAction.cpp

Lines 77 to 85 in f0a4087

	if (block.getRSResult().allMatch())
	{
	block.insert(
	filter_column,
	header.safeGetByPosition(filter_column)); // Make some checks on block structure happy.
	if (return_filter)
	res_filter = nullptr;
	return true;
	}

In LateMaterializationBlockInputStream, filter_column_stream does not execute projecting to remove filter column, and will execute filtering in

tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp

Lines 72 to 75 in f0a4087

	for (auto & col : filter_column_block)
	{
	col.column = col.column->filter(col_filter, passed_count);
	}

This result issue #9348.

What is changed and how it works?

Skip filtering for filter column as

tiflash/dbms/src/Storages/DeltaMerge/LateMaterializationBlockInputStream.cpp

Lines 113 to 117 in f0a4087

	for (auto & col : filter_column_block)
	{
	if (col.name == filter_column_name)
	continue;
	col.column = col.column->filter(*filter, passed_count);

Add add unit-test for this case.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[CalvinNeo]

lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-26 05:43:27.647344853 +0000 UTC m=+762602.781794974: ☑️ agreed by Lloyd-Pottiger.
• 2024-08-26 05:51:43.06623896 +0000 UTC m=+763098.200689083: ☑️ agreed by CalvinNeo.

[Lloyd-Pottiger]

/cherry-pick release-7.5

[ti-chi-bot]

@Lloyd-Pottiger: new pull request created to branch release-7.5: #9480.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Lloyd-Pottiger]

/cherry-pick release-8.1

[Lloyd-Pottiger]

/cherry-pick release-7.1

[ti-chi-bot]

@Lloyd-Pottiger: new pull request created to branch release-8.1: #9481.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@Lloyd-Pottiger: new pull request created to branch release-7.1: #9482.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.