Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add workflow in CMakePresets #9304

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Aug 9, 2024

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

*: add workflow in CMakePresets
$ cmake --list-presets        
Available configure presets:

  "dev"          - Development: DEBUG build with tests enabled
  "dev-coverage" - Development: DEBUG build with tests and code coverage enabled
  "release"      - Release: RELWITHDEBINFO build without tests enabled
  "asan"         - AddressSanitizer: ASAN build with tests enabled
  "tsan"         - ThreadSanitizer: TSAN build with tests enabled
  "benchmarks"   - Benchmarks: RELEASE build with benchmarks enabled

$ cmake --build --list-presets
Available build presets:

  "dev"              - Build tiflash binary with debug info and tests enabled
  "unit-tests"       - Build dbms unit tests
  "unit-tests-all"   - Build all unit tests
  "dev-coverage"     - Build dbms unit tests with code coverage
  "dev-coverage-all" - Build all unit tests with code coverage
  "release"          - Build tiflash binary without debug info
  "asan"             - Build dbms Address Sanitizer tests
  "asan-all"         - Build all Address Sanitizer tests
  "tsan"             - Build dbms ThreadSanitizer tests
  "tsan-all"         - Build all ThreadSanitizer tests
  "benchmarks"       - Build benchmarks

$ cmake --workflow --list-presets
Available workflow presets:

  "dev"            - Build debug binary workflow
  "unit-tests"     - Build dbms unit tests workflow
  "unit-tests-all" - Build all unit tests workflow
  "benchmarks"     - Build benchmarks workflow
  "asan-tests"     - Build dbms Address Sanitizer tests workflow
  "asan-tests-all" - Build all Address Sanitizer tests workflow
  "tsan-tests"     - Build dbms ThreadSanitizer tests workflow
  "tsan-tests-all" - Build all ThreadSanitizer tests workflow
  "release"        - Build release binary workflow

$ cmake --workflow --preset benchmarks
Executing workflow step 1 of 2: configure preset "benchmarks"

Preset CMake variables:

  CMAKE_BUILD_TYPE="RELEASE"
  ENABLE_TESTS="ON"

-- Using compiler:
...

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

CMakePresets.json Outdated Show resolved Hide resolved
CMakePresets.json Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 13, 2024
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-13 06:02:08.382624202 +0000 UTC m=+247813.086093845: ☑️ agreed by JaySon-Huang.
  • 2024-08-13 06:30:39.610114312 +0000 UTC m=+249524.313583954: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 9d130eb into pingcap:master Aug 13, 2024
5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the define-workflow branch August 15, 2024 02:47
@JaySon-Huang JaySon-Huang mentioned this pull request Oct 15, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants