ddl: Atomic rename DeltaMergeStore::db_name in memory
#9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
JaySon-Huang
changed the title
DeltaMergeStore::db_name in memory
ti-chi-bot
bot
added
needs-1-more-lgtm
JaySon-Huang
commented
Jul 23, 2024
| "GC - Merge skipped because current segment is not small, segment={} table={}", | ||
| segment->simpleInfo(), | ||
| table_name); | ||
| LOG_TRACE(log, "GC - Merge skipped because current segment is not small, segment={}", segment->simpleInfo()); |
There was a problem hiding this comment.
Note: The logger of DeltaMergeStore contains the keyspace and table_id as a suffix. So we don't need to log down the table_name in these methods.
|
/test pull-unit-test |
JinheLin
approved these changes
Jul 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Dec 2, 2024
ref pingcap#9233 Make renaming `DeltaMergeStore::db_name` to be atomic
12 tasks
ti-chi-bot
bot
added
the
needs-cherry-pick-release-7.5
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
ref #9233 Make renaming `DeltaMergeStore::db_name` to be atomic Signed-off-by: JaySon-Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9233
Problem Summary:
A part of fixing #9233. In the previous code, updating
DeltaMergeStore::db_nameis not atomic.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note