Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sleep time for sanitizer build type of gtest_compute_server #9194

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Change sleep time for sanitizer build type of gtest_compute_server #9194

merged 3 commits into from
Jul 8, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Jul 8, 2024

What problem does this PR solve?

Issue Number: ref #8285

Problem Summary:

#8285 (comment)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Jul 8, 2024

/run-all-tests

@yibin87
Fix format issue
743dd5b 
Signed-off-by: yibin <[email protected]>
@yibin87
Copy link
Contributor Author

yibin87 commented Jul 8, 2024

/test pull-integration-test

@yibin87
Copy link
Contributor Author

yibin87 commented Jul 8, 2024

/test unit-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Jul 8, 2024

/test pull-unit-test

xzhangxian1008
xzhangxian1008 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 8, 2024
windtalker
windtalker approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-08 05:01:20.282024568 +0000 UTC m=+247377.517258681: ☑️ agreed by xzhangxian1008.
  • 2024-07-08 05:02:29.343077471 +0000 UTC m=+247446.578311584: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit ce637fe into pingcap:master Jul 8, 2024
5 checks passed
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2024
@yibin87
Adjust sanitizer sleep time for cancelMPPGather (#9200)
cd2d7e6 
ref #8285

In #9194, sleep time is changed to 8s in sanitizer mode. However, the case still failed occasionally. So change to a larger time span.

Signed-off-by: yibin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yibin87 @windtalker @xzhangxian1008