security: Add "marker" mode for log densensitation #9136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
release-note
| @@ -221,57 +221,121 @@ String FieldVisitorToString::operator()(const Tuple & x_def) const | |||
|
|
|||
| String FieldVisitorToDebugString::operator()(const Null &) const | |||
There was a problem hiding this comment.
Can we use template to reduce similar code?
There was a problem hiding this comment.
The UInt64/Int64/DecimalField<...> share the similar code, but other types are not.
We can try to eliminate it using std::enable_if, but it is not related to this PR change, maybe we can do it in another PR.
JinheLin
approved these changes
Jun 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Lloyd-Pottiger
approved these changes
Jun 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8977
Problem Summary:
In the previous PR, #1277, tiflash support setting
security.redact_info_logto be set as "true" / "false".If the configuration item is set to true, all user data in the log is replaced by
?.What is changed and how it works?
Mark sensitive data with
‹..›. whensecurity.redact_info_log=marker. Note that‹is not "less"<but U+2039. If the raw data contains‹,‹will be escaped to‹‹, similar to›.Introduce
Redact::toMarkerStringto handle marking sensitive data with‹..›and escaping.Check List
Tests
Side effects
Documentation
Release note