-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVStore: Log when meets any commit_ts < observed max_read_tso #8991
KVStore: Log when meets any commit_ts < observed max_read_tso #8991
Conversation
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
} while (scanner.hasNext()); | ||
if unlikely (error_prone_count > 0) | ||
{ | ||
LOG_INFO( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use warning level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me first run in INFO level to see if the log if overwhelming? I'm afraid that will cause too many logs in error.log
"Error prone txn commit error_prone_count={} min_tso={} read_tso={} region_id={} applied_index={}", | ||
error_prone_count, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Error prone txn commit error_prone_count={} min_tso={} read_tso={} region_id={} applied_index={}", | |
error_prone_count, | |
"Error prone txn commit, error_prone_count={} tot_count={} min_tso={} read_tso={} region_id={} applied_index={}", | |
error_prone_count, | |
data_list_read.size(), |
I've pushed a commit to log down the int64 handles when |
Signed-off-by: CalvinNeo <[email protected]>
…/tics into log-when-abnormal-max-ts
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-7.1 from head ti-chi-bot:cherry-pick-8991-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-8991-to-release-7.1."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: ref #8845
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note