Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: support bitpacking #8969

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Common: support bitpacking #8969

merged 9 commits into from
Apr 25, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #8789

Problem Summary:

What is changed and how it works?

Using https://github.com/lemire/FastPFor to support Bit-Packing encoding. But it only supports 32bits and 64 bits, so most of the codes come from https://github.com/duckdb/duckdb/tree/main/third_party/fastpforlib

Part of #8903

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 19, 2024
JaySon-Huang
JaySon-Huang reviewed Apr 22, 2024
View reviewed changes
contrib/fastpforlib/bitpacking.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why copying the files rather than adding them as submodule? It may bring trouble when we want to update the version of fastpfor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using https://github.com/lemire/FastPFor to support Bit-Packing encoding. But it only supports 32bits and 64 bits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/powturbo/TurboPFor-Integer-Compression is the best, but it is GPL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the bitpacking in FastPFor? https://github.com/lemire/FastPFor/blob/master/headers/blockpacking.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only supports 32bits.

@Lloyd-Pottiger
Common: support bitpacking
64deccb 
Signed-off-by: Lloyd-Pottiger <[email protected]>
Lloyd-Pottiger and others added 3 commits April 23, 2024 17:42
@Lloyd-Pottiger
Merge pull request #12 from JinheLin/pr_8969_min_max
698ff1a 
Use minmax_element
@Lloyd-Pottiger
wa
862acf2 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
refine
d92f1eb 
Signed-off-by: Lloyd-Pottiger <[email protected]>
CalvinNeo
CalvinNeo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 24, 2024
@Lloyd-Pottiger Lloyd-Pottiger requested a review from JinheLin April 25, 2024 02:26
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-24 04:51:23.314404824 +0000 UTC m=+149440.054307761: ☑️ agreed by CalvinNeo.
  • 2024-04-25 03:25:25.595532145 +0000 UTC m=+230682.335435057: ☑️ agreed by JinheLin.

@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 71faa8d into pingcap:master Apr 25, 2024
6 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the support-pfor branch April 25, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@JinheLin JinheLin JinheLin approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lloyd-Pottiger @JaySon-Huang @CalvinNeo @JinheLin