Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: some streams do not need to inherit IProfilingBlockInputStream #8965

Merged
merged 5 commits into from
Apr 19, 2024
Merged

*: some streams do not need to inherit IProfilingBlockInputStream #8965

merged 5 commits into from
Apr 19, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

  1. BlockInputstream used in storage layer except UnorderedInputStream and DMSegmentThreadInputStream do not need to inherit IProfilingBlockInputStream.
  2. Remove some useless files.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
remove useless code
a96c334 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 18, 2024
@Lloyd-Pottiger
format
3c97155 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
tidy
0870eab 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
tidy
81c3550 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 19, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

CalvinNeo
CalvinNeo approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-19 04:00:46.516745684 +0000 UTC m=+569865.627792133: ☑️ agreed by JaySon-Huang.
  • 2024-04-19 08:15:15.257171665 +0000 UTC m=+585134.368218114: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 536390a into pingcap:master Apr 19, 2024
6 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the not-IProfilingBlockInputStream branch May 8, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lloyd-Pottiger @JaySon-Huang @CalvinNeo @JinheLin