Storages: Refine log #8963
Merged
Storages: Refine log #8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
|
/run-all-tests |
Lloyd-Pottiger
approved these changes
Apr 18, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -126,7 +126,7 @@ class SegmentReadTaskPool | |||
| auto blk_avg_bytes = total_count > 0 ? total_bytes / total_count : 0; | |||
| auto approximate_max_pending_block_bytes = blk_avg_bytes * max_queue_size; | |||
| auto total_rows = blk_stat.totalRows(); | |||
| LOG_DEBUG( | |||
| LOG_INFO( | |||
There was a problem hiding this comment.
- Is there only 1 SegmentReadTaskPool for one TableScan?
- If it helps locate the performance issue of ReadThreads, consider adding it to ScanContext?
There was a problem hiding this comment.
- Yes
- It can be added to ScanContext, but not add all of them directly, need some considerations.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
approved these changes
Apr 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
size/XL
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8864
What is changed and how it works?
DeltaMergeStore::readand look quite repetitive. So combine them into one.~SegmentReadTaskPool()into info log.Check List
Tests
Side effects
Documentation
Release note