ddl: Fix logging cause by non-dropped table

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #8911

Problem Summary:

After #8910, if some tables are not able to be dropped, SchemaSyncService::gcImpl will run again with the same gc_safepoint.
But in this path, SchemaSyncService::gcImpl always return true. So if there are some tables can not be dropped for some bugs, then this function will run again and again and print lots of loggings.

What is changed and how it works?

if succeeded == false, then let SchemaSyncService::gcImpl run again after ddl_sync_interval_seconds

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[JaySon-Huang]

/run-all-tests

[JaySon-Huang]

/run-unit-test

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-17 13:37:55.66591487 +0000 UTC m=+431694.776961326: ☑️ agreed by Lloyd-Pottiger.
• 2024-04-17 14:54:25.560938127 +0000 UTC m=+436284.671984577: ☑️ agreed by JinheLin.

[ti-chi-bot]

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[JaySon-Huang]

/run-unit-test

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #8958.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #8961.