Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch exception of LocalAdmissionController::stop() #8942

Merged
merged 4 commits into from
Apr 12, 2024
Merged

catch exception of LocalAdmissionController::stop() #8942

merged 4 commits into from
Apr 12, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Apr 12, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #8860

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that in the disaggregated storage and compute architecture, TiFlash might panic during shutdown

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2024
@guo-shaoge
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 12, 2024
yibin87
yibin87 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 12, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 06:04:02.450869355 +0000 UTC m=+1201503.978409901: ☑️ agreed by JaySon-Huang.
  • 2024-04-12 07:14:09.16598843 +0000 UTC m=+1205710.693528977: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit 0b0cc45 into pingcap:master Apr 12, 2024
6 checks passed
@JaySon-Huang JaySon-Huang deleted the lac_safe_stop branch April 12, 2024 08:27
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 12, 2024
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 12, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9050.

This was referenced May 16, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2024
@ti-chi-bot
catch exception of LocalAdmissionController::stop() (#8942) (#9050)
51cd8aa 
close #8860
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 20, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#8942
489e0a7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9062.

This was referenced May 20, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 20, 2024
@ti-chi-bot
catch exception of LocalAdmissionController::stop() (#8942) (#9062)
f032a2e 
close #8860
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
catch exception of LocalAdmissionController::stop() (pingcap#8942) (p…
96815a8 
…ingcap#9062)

close pingcap#8860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash may crash when stopping, "resource manager grpc call failed: AcquireTokenBuckets"
4 participants
@guo-shaoge @ti-chi-bot @JaySon-Huang @yibin87