Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disagg: fix used size metrics of FileCache #8921

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Disagg: fix used size metrics of FileCache #8921

merged 2 commits into from
Apr 9, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Apr 9, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #8920

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

    • Run queries and make used size of file cache growth.
    • Update config make size limitation of file cache smaller.
    • Restart CNs.
    • Before this PR, the used size of metrics is underflow:
      zJBKLgWEeq
    • After this PR, the used size of metrics meet expectations:
      uvVX5ejYDB

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that the store used size of compute node is not correct after changing the remote cache capacity under disaggregated arch

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2024
JaySon-Huang
JaySon-Huang approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 9, 2024
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JinheLin
Copy link
Contributor Author

JinheLin commented Apr 9, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 11:16:13.328797939 +0000 UTC m=+961034.856338481: ☑️ agreed by JaySon-Huang.
  • 2024-04-09 12:55:04.222658811 +0000 UTC m=+966965.750199356: ☑️ agreed by Lloyd-Pottiger.

@JinheLin
Copy link
Contributor Author

JinheLin commented Apr 9, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit da10aa6 into pingcap:master Apr 9, 2024
6 checks passed
@JinheLin
Copy link
Contributor Author

JinheLin commented Apr 9, 2024

/run-cherry-pick

@JinheLin
Copy link
Contributor Author

JinheLin commented Apr 9, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@JinheLin: new pull request created to branch release-7.5: #8923.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 9, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#8921
ed98882 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
12 tasks
@JinheLin
Copy link
Contributor Author

JinheLin commented Apr 9, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@JinheLin: new pull request created to branch release-8.1: #8924.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2024
@ti-chi-bot
Disagg: fix used size metrics of FileCache (#8921) (#8924)
c4e1f91 
close #8920
ti-chi-bot bot pushed a commit that referenced this pull request Apr 10, 2024
@ti-chi-bot
Disagg: fix used size metrics of FileCache (#8921) (#8923)
e844048 
close #8920
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 10, 2024
@ti-chi-bot ti-chi-bot bot removed the release-note-none Denotes a PR that doesn't merit a release note. label Apr 10, 2024
@JinheLin JinheLin deleted the fix_file_cache_metrics branch April 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The store used_size of compute node is not correct after restarting with smaller capacity
4 participants
@JinheLin @JaySon-Huang @ti-chi-bot @Lloyd-Pottiger