Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Fix build on mac #8236

Merged
merged 1 commit into from
Oct 24, 2023
Merged

*: Fix build on mac #8236

merged 1 commit into from
Oct 24, 2023
+1 −1

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 24, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6233

Problem Summary: Fix build on mac

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 24, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 24, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 24, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-24 06:02:52.246127509 +0000 UTC m=+2328169.833237640: ☑️ agreed by JinheLin.
  • 2023-10-24 06:53:06.034690189 +0000 UTC m=+2331183.621800319: ☑️ agreed by breezewish.

@ti-chi-bot ti-chi-bot bot merged commit 2914d44 into pingcap:master Oct 24, 2023
@JaySon-Huang JaySon-Huang deleted the fix_mac branch October 25, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@breezewish breezewish breezewish approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

@Lloyd-Pottiger Lloyd-Pottiger Awaiting requested review from Lloyd-Pottiger

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine code or doc
3 participants
@JaySon-Huang @breezewish @JinheLin