Storage: add RSOperator batch check

[Lloyd-Pottiger]

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #6295

Problem Summary:

What is changed and how it works?

add RSOperator batch check

• avoid getting rsindex continuously
• batch compute handle_res

TODO:

• To further improve performance, we will let RSRusult be a bool.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/cc @hehechen @hongyunyan @JaySon-Huang

[hongyunyan]

Could you please give a microbenchmark result to show the performance gain by batch check?

[hongyunyan]

I think maybe L194 in dbms/src/Storages/DeltaMerge/File/DMFilePackFilter.h can also use batch check to make optimzation?

[Lloyd-Pottiger]

Could you please give a microbenchmark result to show the performance gain by batch check?

minor changes, so no benchmark. And it is necessary to generate a large number of packs in order to see the implementation, so...

I think maybe L194 in dbms/src/Storages/DeltaMerge/File/DMFilePackFilter.h can also use batch check to make optimization?

yes, I missed it, I will do that.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lloyd-pottiger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment