Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: remove delta mode of execution summary #6271

Merged
merged 7 commits into from
Nov 10, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Nov 7, 2022

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 7, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 7, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 7, 2022

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 8, 2022

/run-all-tests

@windtalker
Copy link
Contributor

I'm not sure if this change compatible with BatchCorpcessor, please help confirm this.

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 9, 2022

I'm not sure if this change compatible with BatchCorpcessor, please help confirm this.

looks ok

  • mpp
+------------------------------------------------+------------+---------+--------------+---------------+---------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------+------+
| id                                             | estRows    | actRows | task         | access object | execution info                                                                                          | operator info                                                                                                                                                           | memory | disk |
+------------------------------------------------+------------+---------+--------------+---------------+---------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------+------+
| TableReader_82                                 | 5.17       | 5       | root         |               | time:1.34s, loops:2, cop_task: {num: 2, max: 0s, min: 0s, avg: 0s, p95: 0s, copr_cache_hit_ratio: 0.00} | data:ExchangeSender_81                                                                                                                                                  | N/A    | N/A  |
| └─ExchangeSender_81                            | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.33s, loops:1, threads:20}                                                          | ExchangeType: PassThrough                                                                                                                                               | N/A    | N/A  |
|   └─Projection_76                              | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.32s, loops:1, threads:20}                                                          | Column#8, Column#9                                                                                                                                                      | N/A    | N/A  |
|     └─HashAgg_74                               | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.32s, loops:1, threads:20}                                                          | group by:Column#36, funcs:sum(Column#34)->Column#8, funcs:sum(Column#35)->Column#9                                                                                      | N/A    | N/A  |
|       └─Projection_84                          | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.32s, loops:1, threads:20}                                                          | cast(test.test.col1, decimal(5,0) UNSIGNED BINARY)->Column#34, cast(test.test.col3, decimal(20,0) BINARY)->Column#35, Column#7                                          | N/A    | N/A  |
|         └─ExchangeReceiver_54                  | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:1, threads:20}                                                          |                                                                                                                                                                         | N/A    | N/A  |
|           └─ExchangeSender_53                  | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:1, threads:20}                                                          | ExchangeType: HashPartition, Hash Cols: [name: Column#7, collate: binary]                                                                                               | N/A    | N/A  |
|             └─Projection_49                    | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:1, threads:20}                                                          | Column#7, test.test.col1, test.test.col3                                                                                                                                | N/A    | N/A  |
|               └─HashAgg_50                     | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:1, threads:20}                                                          | group by:test.test.col1, test.test.col3, funcs:sum(Column#19)->Column#7, funcs:firstrow(test.test.col1)->test.test.col1, funcs:firstrow(test.test.col3)->test.test.col3 | N/A    | N/A  |
|                 └─ExchangeReceiver_52          | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.3s, loops:1, threads:20}                                                           |                                                                                                                                                                         | N/A    | N/A  |
|                   └─ExchangeSender_51          | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:1, threads:2}                                                           | ExchangeType: HashPartition, Hash Cols: [name: test.test.col1, collate: binary], [name: test.test.col3, collate: binary]                                                | N/A    | N/A  |
|                     └─HashAgg_45               | 5.17       | 5       | mpp[tiflash] |               | tiflash_task:{time:1.3s, loops:1, threads:2}                                                            | group by:Column#32, Column#33, funcs:sum(Column#31)->Column#19                                                                                                          | N/A    | N/A  |
|                       └─Projection_83          | 2322880.00 | 2322880 | mpp[tiflash] |               | tiflash_task:{time:848.4ms, loops:37, threads:2}                                                        | cast(test.test.col2, double BINARY)->Column#31, test.test.col1, test.test.col3                                                                                          | N/A    | N/A  |
|                         └─TableFullScan_34     | 2322880.00 | 2322880 | mpp[tiflash] | table:test    | tiflash_task:{time:181.4ms, loops:37, threads:2}                                                        | keep order:false                                                                                                                                                        | N/A    | N/A  |
+------------------------------------------------+------------+---------+--------------+---------------+---------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------+------+
  • batchCop
+----------------------------------+------------+---------+-------------------+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| id                               | estRows    | actRows | task              | access object | execution info                                                                                                                                                                                                                                                                                                                                                        | operator info                                                                                                                                                           | memory    | disk |
+----------------------------------+------------+---------+-------------------+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| HashAgg_9                        | 5.17       | 5       | root              |               | time:1.16s, loops:4, partial_worker:{wall_time:1.158933148s, concurrency:5, task_num:4, tot_wait:5.794392244s, tot_exec:73.671µs, tot_time:5.794488045s, max:1.158902885s, p95:1.158902885s}, final_worker:{wall_time:1.15898255s, concurrency:5, task_num:4, tot_wait:5.794554389s, tot_exec:139.034µs, tot_time:5.794698452s, max:1.158953888s, p95:1.158953888s}   | group by:Column#18, funcs:sum(Column#16)->Column#8, funcs:sum(Column#17)->Column#9                                                                                      | 37.9 KB   | N/A  |
| └─Projection_19                  | 5.17       | 5       | root              |               | time:1.16s, loops:5, Concurrency:OFF                                                                                                                                                                                                                                                                                                                                  | cast(test.test.col1, decimal(5,0) UNSIGNED BINARY)->Column#16, cast(test.test.col3, decimal(20,0) BINARY)->Column#17, Column#7                                          | 1.11 KB   | N/A  |
|   └─HashAgg_14                   | 5.17       | 5       | root              |               | time:1.16s, loops:5, partial_worker:{wall_time:1.158761518s, concurrency:5, task_num:1, tot_wait:5.793408843s, tot_exec:28.892µs, tot_time:5.793454968s, max:1.158731855s, p95:1.158731855s}, final_worker:{wall_time:1.158790169s, concurrency:5, task_num:4, tot_wait:5.793568277s, tot_exec:248.29µs, tot_time:5.79382232s, max:1.158774266s, p95:1.158774266s}    | group by:test.test.col1, test.test.col3, funcs:sum(Column#10)->Column#7, funcs:firstrow(test.test.col1)->test.test.col1, funcs:firstrow(test.test.col3)->test.test.col3 | 17.3 KB   | N/A  |
|     └─TableReader_15             | 5.17       | 5       | root              |               | time:1.16s, loops:2, cop_task: {num: 2, max: 0s, min: 0s, avg: 0s, p95: 0s, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15}                                                                                                                                                                                                                                      | data:HashAgg_10                                                                                                                                                         | 152 Bytes | N/A  |
|       └─HashAgg_10               | 5.17       | 5       | batchCop[tiflash] |               | tiflash_task:{time:1.15s, loops:1, threads:2}                                                                                                                                                                                                                                                                                                                         | group by:Column#14, Column#15, funcs:sum(Column#13)->Column#10                                                                                                          | N/A       | N/A  |
|         └─Projection_18          | 2322880.00 | 2322880 | batchCop[tiflash] |               | tiflash_task:{time:743.9ms, loops:37, threads:2}                                                                                                                                                                                                                                                                                                                      | cast(test.test.col2, double BINARY)->Column#13, test.test.col1, test.test.col3                                                                                          | N/A       | N/A  |
|           └─TableFullScan_13     | 2322880.00 | 2322880 | batchCop[tiflash] | table:test    | tiflash_task:{time:77.9ms, loops:37, threads:2}                                                                                                                                                                                                                                                                                                                       | keep order:false                                                                                                                                                        | N/A       | N/A  |
+----------------------------------+------------+---------+-------------------+---------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
  • cop
+----------------------------------+------------+---------+--------------+---------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| id                               | estRows    | actRows | task         | access object | execution info                                                                                                                                                                                                                                                                                                                                                       | operator info                                                                                                                                                           | memory    | disk |
+----------------------------------+------------+---------+--------------+---------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+
| HashAgg_9                        | 5.17       | 5       | root         |               | time:1.23s, loops:4, partial_worker:{wall_time:1.225490746s, concurrency:5, task_num:4, tot_wait:6.127030474s, tot_exec:31.683µs, tot_time:6.127071437s, max:1.225452897s, p95:1.225452897s}, final_worker:{wall_time:0s, concurrency:5, task_num:4, tot_wait:6.12737545s, tot_exec:80.303µs, tot_time:6.127458778s, max:1.225499416s, p95:1.225499416s}             | group by:Column#18, funcs:sum(Column#16)->Column#8, funcs:sum(Column#17)->Column#9                                                                                      | 37.9 KB   | N/A  |
| └─Projection_19                  | 5.17       | 5       | root         |               | time:1.23s, loops:5, Concurrency:OFF                                                                                                                                                                                                                                                                                                                                 | cast(test.test.col1, decimal(5,0) UNSIGNED BINARY)->Column#16, cast(test.test.col3, decimal(20,0) BINARY)->Column#17, Column#7                                          | 1.11 KB   | N/A  |
|   └─HashAgg_14                   | 5.17       | 5       | root         |               | time:1.23s, loops:5, partial_worker:{wall_time:1.225280629s, concurrency:5, task_num:1, tot_wait:6.12612229s, tot_exec:37.253µs, tot_time:6.126172144s, max:1.225264616s, p95:1.225264616s}, final_worker:{wall_time:1.225299391s, concurrency:5, task_num:4, tot_wait:6.126260169s, tot_exec:143.743µs, tot_time:6.12640806s, max:1.225288809s, p95:1.225288809s}   | group by:test.test.col1, test.test.col3, funcs:sum(Column#10)->Column#7, funcs:firstrow(test.test.col1)->test.test.col1, funcs:firstrow(test.test.col3)->test.test.col3 | 17.3 KB   | N/A  |
|     └─TableReader_15             | 5.17       | 10      | root         |               | time:1.23s, loops:2, cop_task: {num: 2, max: 1.23s, min: 1.15s, avg: 1.19s, p95: 1.23s, rpc_num: 2, rpc_time: 2.38s, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15}                                                                                                                                                                                            | data:HashAgg_10                                                                                                                                                         | 638 Bytes | N/A  |
|       └─HashAgg_10               | 5.17       | 10      | cop[tiflash] |               | tiflash_task:{proc max:1.22s, min:1.14s, avg: 1.18s, p80:1.22s, p95:1.22s, iters:2, tasks:2, threads:2}                                                                                                                                                                                                                                                              | group by:Column#14, Column#15, funcs:sum(Column#13)->Column#10                                                                                                          | N/A       | N/A  |
|         └─Projection_18          | 2322880.00 | 2322880 | cop[tiflash] |               | tiflash_task:{proc max:791.5ms, min:714.9ms, avg: 753.2ms, p80:791.5ms, p95:791.5ms, iters:37, tasks:2, threads:2}                                                                                                                                                                                                                                                   | cast(test.test.col2, double BINARY)->Column#13, test.test.col1, test.test.col3                                                                                          | N/A       | N/A  |
|           └─TableFullScan_13     | 2322880.00 | 2322880 | cop[tiflash] | table:test    | tiflash_task:{proc max:146.5ms, min:57.9ms, avg: 102.2ms, p80:146.5ms, p95:146.5ms, iters:37, tasks:2, threads:2}                                                                                                                                                                                                                                                    | keep order:false                                                                                                                                                        | N/A       | N/A  |
+----------------------------------+------------+---------+--------------+---------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------+------+

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 9, 2022

And

  • mpp
+-------------------------+------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------+---------------------------+--------+------+
| id                      | estRows    | actRows | task         | access object | execution info                                                                                              | operator info             | memory | disk |
+-------------------------+------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------+---------------------------+--------+------+
| TableReader_9           | 2322880.00 | 2322880 | root         |               | time:1.33s, loops:2270, cop_task: {num: 38, max: 0s, min: 0s, avg: 0s, p95: 0s, copr_cache_hit_ratio: 0.00} | data:ExchangeSender_8     | N/A    | N/A  |
| └─ExchangeSender_8      | 2322880.00 | 2322880 | mpp[tiflash] |               | tiflash_task:{time:1.31s, loops:37, threads:2}                                                              | ExchangeType: PassThrough | N/A    | N/A  |
|   └─TableFullScan_7     | 2322880.00 | 2322880 | mpp[tiflash] | table:test    | tiflash_task:{time:65.1ms, loops:37, threads:2}                                                             | keep order:false          | N/A    | N/A  |
+-------------------------+------------+---------+--------------+---------------+-------------------------------------------------------------------------------------------------------------+---------------------------+--------+------+
  • batchCop
+-----------------------+------------+---------+-------------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+
| id                    | estRows    | actRows | task              | access object | execution info                                                                                                                       | operator info        | memory  | disk |
+-----------------------+------------+---------+-------------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+
| TableReader_5         | 2322880.00 | 2322880 | root              |               | time:3.03s, loops:2270, cop_task: {num: 38, max: 0s, min: 0s, avg: 0s, p95: 0s, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15} | data:TableFullScan_4 | 2.32 MB | N/A  |
| └─TableFullScan_4     | 2322880.00 | 2322880 | batchCop[tiflash] | table:test    | tiflash_task:{time:230.3ms, loops:37, threads:2}                                                                                     | keep order:false     | N/A     | N/A  |
+-----------------------+------------+---------+-------------------+---------------+--------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+
  • cop
+-----------------------+------------+---------+--------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+
| id                    | estRows    | actRows | task         | access object | execution info                                                                                                                                                               | operator info        | memory  | disk |
+-----------------------+------------+---------+--------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+
| TableReader_5         | 2322880.00 | 2322880 | root         |               | time:1.96s, loops:2271, cop_task: {num: 2, max: 1.96s, min: 1.78s, avg: 1.87s, p95: 1.96s, rpc_num: 2, rpc_time: 3.73s, copr_cache_hit_ratio: 0.00, distsql_concurrency: 15} | data:TableFullScan_4 | 82.1 MB | N/A  |
| └─TableFullScan_4     | 2322880.00 | 2322880 | cop[tiflash] | table:test    | tiflash_task:{proc max:200.5ms, min:69ms, avg: 134.7ms, p80:200.5ms, p95:200.5ms, iters:37, tasks:2, threads:2}                                                              | keep order:false     | N/A     | N/A  |
+-----------------------+------------+---------+--------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------+---------+------+

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e19e9d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 10, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Nov 10, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 202f1f5 into pingcap:master Nov 10, 2022
@SeaRise SeaRise deleted the remove_summary_delte branch November 10, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants