Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Fix RegionBlockReaderTest helper functions #5899

Merged
merged 3 commits into from
Sep 16, 2022
Merged

tests: Fix RegionBlockReaderTest helper functions #5899

merged 3 commits into from
Sep 16, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 15, 2022 •
edited
Loading

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: ref #5859

Problem Summary:
The helper functions in RegionBlockReaderTestFixture is buggy when testing with primary key columns.

What is changed and how it works?

Fix the testing helper functions.
A pre-split PR for #5879

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hongyunyan
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2022
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 15, 2022
Merged
12 tasks
@JaySon-Huang JaySon-Huang force-pushed the refine_RegionBlockReaderTest branch from 8f8ed67 to 451ca9f Compare September 15, 2022 08:10
@JaySon-Huang
Fix null col
8f64046 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang force-pushed the refine_RegionBlockReaderTest branch from 451ca9f to 8f64046 Compare September 15, 2022 08:10
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 15, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Storages/Transaction/RowCodec.cpp                                244                34    86.07%          19                 0   100.00%         393                59    84.99%         204                45    77.94%
Storages/Transaction/tests/RowCodecTestUtils.h                    84                 4    95.24%          14                 0   100.00%         173                 1    99.42%          42                 6    85.71%
Storages/Transaction/tests/gtest_region_block_reader.cpp         161                24    85.09%          23                 1    95.65%         295                12    95.93%          44                 5    88.64%
TestUtils/TiFlashTestBasic.cpp                                     8                 5    37.50%           2                 1    50.00%          11                 7    36.36%           4                 3    25.00%
TestUtils/TiFlashTestBasic.h                                       4                 0   100.00%           2                 0   100.00%          12                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                            501                67    86.63%          60                 2    96.67%         884                79    91.06%         296                59    80.07%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18754      8129             56.65%    217233  83519        61.55%

full coverage report (for internal network access only)

lidezhu
lidezhu approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2022
@JaySon-Huang
Copy link
Contributor Author

/cc @hongyunyan

hongyunyan
hongyunyan approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2022
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8f64046

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5916.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
603ff72 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5917.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
9bdb558 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Sep 16, 2022
Merged
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5918.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5919.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
ad926db 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
01cbc43 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5921.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5922.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
8145edc 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5923.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
5ba942d 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Sep 16, 2022
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5924.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
5ac7b24 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 16, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5925.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 16, 2022
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#5899
fd1a0cb 
Signed-off-by: ti-chi-bot <[email protected]>
@JaySon-Huang JaySon-Huang deleted the refine_RegionBlockReaderTest branch September 16, 2022 07:26
ti-chi-bot added a commit that referenced this pull request Sep 26, 2022
@ti-chi-bot
tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924)
8fc3b1c 
ref #5859
ti-chi-bot added a commit that referenced this pull request Sep 26, 2022
@ti-chi-bot
tests: Fix RegionBlockReaderTest helper functions (#5899) (#5917)
0438e86 
ref #5859
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 27, 2022
@ti-chi-bot @JaySon-Huang
tests: Fix RegionBlockReaderTest helper functions (pingcap#5899) (pin…
04c303a 
…gcap#5924)

ref pingcap#5859
JaySon-Huang added a commit that referenced this pull request Oct 31, 2022
@JaySon-Huang @ti-chi-bot
Fix two DDL bugs on hotfix branch (#6042)
f0d54d6 
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191)

close #5154

* tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924)

ref #5859

* Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932)

close #5859

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-chi-bot @sre-bot @hongyunyan @lidezhu