Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the results of tikv and tiflash are different #5839

Merged
merged 12 commits into from
Sep 14, 2022
Merged

fix: the results of tikv and tiflash are different #5839

merged 12 commits into from
Sep 14, 2022

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Sep 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5849, close pingcap/tidb#37258

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2022
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @SeaRise

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed do-not-merge/needs-triage-completed labels Sep 13, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Sep 13, 2022

Please add unit test in gtest_logical.cpp.

@xzhangxian1008
Copy link
Contributor Author

Please add unit test in gtest_logical.cpp.

okk

@ti-chi-bot ti-chi-bot merged commit 624a10a into pingcap:master Sep 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5868.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 14, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#5839
92e5551 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5869.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 14, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#5839
270fb7d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5870.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5871.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5872.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5873.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 14, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#5839
cf9a481 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Sep 14, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5874.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5875.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5876.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 14, 2022
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#5839
7a9d152 
Signed-off-by: ti-chi-bot <[email protected]>
@xzhangxian1008 xzhangxian1008 deleted the issue_37258 branch September 14, 2022 03:45
ti-chi-bot added a commit that referenced this pull request Sep 14, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5874)
70bbf76 
close #5849, close pingcap/tidb#37258
ti-chi-bot added a commit that referenced this pull request Sep 20, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5873)
d861633 
close #5849, close pingcap/tidb#37258
ti-chi-bot added a commit that referenced this pull request Sep 20, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5868)
2cf9e3b 
close #5849, close pingcap/tidb#37258
ti-chi-bot added a commit that referenced this pull request Sep 20, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5871)
b9e1871 
close #5849, close pingcap/tidb#37258
ti-chi-bot added a commit that referenced this pull request Sep 20, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5870)
f39985e 
close #5849, close pingcap/tidb#37258
ti-chi-bot added a commit that referenced this pull request Sep 20, 2022
@ti-chi-bot
fix: the results of tikv and tiflash are different (#5839) (#5869)
a21e24c 
close #5849, close pingcap/tidb#37258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the results of tikv and tiflash are different the results of tikv and tiflash are different
5 participants
@xzhangxian1008 @ti-chi-bot @SeaRise @sre-bot @windtalker