Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SquashingBlockInputStream for delta stream in fast mode #5396

Closed
wants to merge 7 commits into from

Conversation

hongyunyan
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #5252

Problem Summary:

What is changed and how it works?

use SquashingBlockInputStream for delta stream in fast mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@hongyunyan
Copy link
Contributor Author

/run-build-arm64

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 18, 2022

@flowbehappy
Copy link
Contributor

We will need some benchmark results before merging it. @hongyunyan

@flowbehappy flowbehappy self-requested a review July 18, 2022 10:15
@hongyunyan
Copy link
Contributor Author

Yes! This PR is now for benchbot test.

@hongyunyan hongyunyan changed the title Use SquashingBlockInputStream for delta stream in fast mode WIP: Use SquashingBlockInputStream for delta stream in fast mode Jul 18, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2022
@hongyunyan
Copy link
Contributor Author

/run-build-arm64

1 similar comment
@hongyunyan
Copy link
Contributor Author

/run-build-arm64

@hongyunyan hongyunyan changed the title WIP: Use SquashingBlockInputStream for delta stream in fast mode [DNM] Use SquashingBlockInputStream for delta stream in fast mode Jul 21, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2022
@hongyunyan
Copy link
Contributor Author

/run-build-arm64

@hongyunyan hongyunyan changed the title [DNM] Use SquashingBlockInputStream for delta stream in fast mode Use SquashingBlockInputStream for delta stream in fast mode Jul 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2022
@hongyunyan
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e3b26a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2022
@ti-chi-bot
Copy link
Member

@hongyunyan: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hongyunyan
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2022
@ti-chi-bot
Copy link
Member

Merge canceled because a new commit is pushed.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2022
@hongyunyan
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 22, 2022

Coverage for changed files

Filename                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Segment.cpp                                                690               210    69.57%          47                 3    93.62%        1170               263    77.52%         366               192    47.54%
tests/gtest_dm_delta_merge_store_for_fast_mode.cpp        1760               361    79.49%          12                 0   100.00%        1402                 5    99.64%         802               228    71.57%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                     2450               571    76.69%          59                 3    94.92%        2572               268    89.58%        1168               420    64.04%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18799      9448             49.74%    214166  95358        55.47%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@hongyunyan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2022
@hongyunyan
Copy link
Contributor Author

/close

@ti-chi-bot
Copy link
Member

@hongyunyan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants