Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planner: Support Planner Interpreter #5321

Merged
merged 26 commits into from
Aug 10, 2022
Merged

Planner: Support Planner Interpreter #5321

merged 26 commits into from
Aug 10, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4739

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support Planner Interpreter.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 8, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@SeaRise SeaRise mentioned this pull request Jul 12, 2022
Closed
13 tasks
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 12, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@SeaRise SeaRise force-pushed the planner_refactory branch from 05fd9bd to 7693e14 Compare July 18, 2022 10:14
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 21, 2022

/label tide/merge-method-rebase

@ti-chi-bot ti-chi-bot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jul 21, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2022
@SeaRise SeaRise removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/label tide/merge-method-merge

ywqzzy
ywqzzy reviewed Aug 9, 2022
View reviewed changes
dbms/src/Flash/Planner/plans/PhysicalJoin.cpp Show resolved Hide resolved
dbms/src/Flash/Planner/plans/PhysicalTopN.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Planner/plans/PhysicalWindowSort.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Planner/FinalizeHelper.cpp Outdated Show resolved Hide resolved
@ywqzzy ywqzzy self-requested a review August 9, 2022 09:06
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 9, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 9, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19243      9241             51.98%    218764  93968        57.05%

full coverage report (for internal network access only)

ywqzzy
ywqzzy reviewed Aug 10, 2022
View reviewed changes
dbms/src/Flash/Coprocessor/FineGrainedShuffle.h Show resolved Hide resolved
dbms/src/Flash/Coprocessor/PushDownFilter.cpp Show resolved Hide resolved
dbms/src/Flash/Planner/PhysicalPlanHelper.h Outdated Show resolved Hide resolved
dbms/src/Flash/Planner/PhysicalPlanVisitor.h
{
/// visit physical plan node tree and apply function.
/// f: (const PhysicalPlanNodePtr &) -> bool, return true to continue visit.
template <typename FF>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in future, we can use visitor pattern in PhysicalPlanNode.

@ywqzzy ywqzzy self-requested a review August 10, 2022 02:15
@SeaRise SeaRise requested a review from ywqzzy August 10, 2022 06:45
ywqzzy
ywqzzy approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbms/src/Flash/Planner/plans/PhysicalUnary.h Outdated Show resolved Hide resolved
dbms/src/Flash/Planner/plans/PhysicalBinary.h Outdated Show resolved Hide resolved
dbms/src/Flash/Planner/plans/PhysicalBinary.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fb13269

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 10, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19245      9240             51.99%    218797  93992        57.04%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f470b46 into master Aug 10, 2022
@JaySon-Huang JaySon-Huang deleted the planner_refactory branch August 10, 2022 11:27
@JaySon-Huang JaySon-Huang mentioned this pull request Aug 10, 2022
Merged
12 tasks
@SeaRise SeaRise mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@windtalker windtalker windtalker approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @fuzhe1989 @ywqzzy