MinMax Index Supports Nullable DataType

[hehechen]

Signed-off-by: hehechen [email protected]

What problem does this PR solve?

Currently, MinMax Index does not support Nullable datatype.
Issue Number: close #4787

Problem Summary:

What is changed and how it works?

We can extract the nested data type from DataTypeNullable and reuse existing MinMax index code.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[hehechen]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataTypes/IDataType.h                                        63                26    58.73%          49                22    55.10%          79                38    51.90%          18                 9    50.00%
Storages/DeltaMerge/File/DMFileWriter.cpp                   111                 7    93.69%          15                 0   100.00%         443                17    96.16%          74                 8    89.19%
Storages/DeltaMerge/Index/MinMaxIndex.cpp                   494                88    82.19%          16                 2    87.50%         417                60    85.61%         250                92    63.20%
Storages/DeltaMerge/Index/MinMaxIndex.h                       6                 0   100.00%           6                 0   100.00%          13                 0   100.00%           0                 0         -
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp        3247               558    82.81%          17                 0   100.00%         277                 0   100.00%         916               463    49.45%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      3921               679    82.68%         103                24    76.70%        1229               115    90.64%        1258               572    54.53%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18331      9653             47.34%    206011  96670        53.08%

full coverage report (for internal network access only)

[JaySon-Huang]

LGTM

[lidezhu]

LGTM

[hehechen]

/merge

[ti-chi-bot]

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: e149f0d

[ti-chi-bot]

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataTypes/IDataType.h                                        63                26    58.73%          49                22    55.10%          79                38    51.90%          18                 7    61.11%
Storages/DeltaMerge/File/DMFileWriter.cpp                   111                 7    93.69%          15                 0   100.00%         443                17    96.16%          74                 8    89.19%
Storages/DeltaMerge/Index/MinMaxIndex.cpp                   494                88    82.19%          16                 2    87.50%         417                60    85.61%         250                91    63.60%
Storages/DeltaMerge/Index/MinMaxIndex.h                       6                 0   100.00%           6                 0   100.00%          13                 0   100.00%           0                 0         -
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp        3247               558    82.81%          17                 0   100.00%         277                 0   100.00%         916               463    49.45%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      3921               679    82.68%         103                24    76.70%        1229               115    90.64%        1258               569    54.77%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18331      9653             47.34%    206011  96683        53.07%

full coverage report (for internal network access only)

[sre-bot]

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataTypes/IDataType.h                                        63                26    58.73%          49                22    55.10%          79                38    51.90%          18                 8    55.56%
Storages/DeltaMerge/File/DMFileWriter.cpp                   111                 7    93.69%          15                 0   100.00%         443                17    96.16%          74                 8    89.19%
Storages/DeltaMerge/Index/MinMaxIndex.cpp                   494                88    82.19%          16                 2    87.50%         417                60    85.61%         250                91    63.60%
Storages/DeltaMerge/Index/MinMaxIndex.h                       6                 0   100.00%           6                 0   100.00%          13                 0   100.00%           0                 0         -
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp        3247               558    82.81%          17                 0   100.00%         277                 0   100.00%         916               463    49.45%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      3921               679    82.68%         103                24    76.70%        1229               115    90.64%        1258               570    54.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18339      9653             47.36%    206279  96639        53.15%

full coverage report (for internal network access only)