Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a unused proxy status api named test-show #5136

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Removed a unused proxy status api named test-show #5136

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4614379
Removed a unused proxy status api named test-show.
jiaqizho Jun 13, 2022
2aaaa2e
Merge branch 'master' into rm-unused-api
ti-chi-bot Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions dbms/src/Storages/Transaction/ProxyFFIStatusService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,6 @@

namespace DB
{
HttpRequestRes HandleHttpRequestTestShow(
EngineStoreServerWrap *,
std::string_view path,
const std::string & api_name,
std::string_view query,
std::string_view body)
{
auto * res = RawCppString::New(fmt::format(
"api_name: {}\npath: {}\nquery: {}\nbody: {}",
api_name,
path,
query,
body));
return HttpRequestRes{
.status = HttpRequestStatus::Ok,
.res = CppStrWithView{
.inner = GenRawCppPtr(res, RawCppPtrTypeImpl::String),
.view = BaseBuffView{res->data(), res->size()}}};
}

HttpRequestRes HandleHttpRequestSyncStatus(
EngineStoreServerWrap * server,
std::string_view path,
Expand Down Expand Up @@ -112,8 +92,7 @@ using HANDLE_HTTP_URI_METHOD = HttpRequestRes (*)(EngineStoreServerWrap *, std::

static const std::map<std::string, HANDLE_HTTP_URI_METHOD> AVAILABLE_HTTP_URI = {
{"/tiflash/sync-status/", HandleHttpRequestSyncStatus},
{"/tiflash/store-status", HandleHttpRequestStoreStatus},
{"/tiflash/test-show", HandleHttpRequestTestShow}};
{"/tiflash/store-status", HandleHttpRequestStoreStatus}};

uint8_t CheckHttpUriAvailable(BaseBuffView path_)
{
Expand Down