Some refinements of `mpp_exchange_receiver_map` and `MPPTunnelSet` #5132

windtalker · 2022-06-13T05:54:52Z

Signed-off-by: xufei [email protected]

What problem does this PR solve?

Issue Number: ref #5095

Problem Summary:

What is changed and how it works?

Move mpp_exchange_receiver_map from DAGContext to MPPTask
Rename id_to_index_map to target_task_id_to_index_map in MPPTunnelSet since the map key is the target task id. So the name is more self-explained.
Add registerTunnels and initExchangeReceivers to setup MPPTunnel and ExchangeReceiver in MPPTask

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: xufei <[email protected]>

ti-chi-bot · 2022-06-13T05:54:53Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

bestwoody
yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

windtalker · 2022-06-13T06:26:40Z

/run-all-tests

sre-bot · 2022-06-13T06:55:30Z

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Coprocessor/DAGContext.cpp             100                64    36.00%          24                11    54.17%         173               107    38.15%          68                52    23.53%
Coprocessor/DAGContext.h                40                13    67.50%          31                11    64.52%          88                33    62.50%          12                 6    50.00%
Coprocessor/DAGUtils.cpp               358               157    56.15%          46                15    67.39%         653               296    54.67%         422               202    52.13%
Coprocessor/DAGUtils.h                   3                 0   100.00%           1                 0   100.00%          12                 0   100.00%           2                 0   100.00%
Coprocessor/InterpreterDAG.cpp          16                 5    68.75%           5                 0   100.00%          50                 8    84.00%          10                 4    60.00%
Mpp/MPPTask.cpp                        451               451     0.00%          24                24     0.00%         390               390     0.00%         198               198     0.00%
Mpp/MPPTask.h                            3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Mpp/MPPTunnelSet.cpp                    63                63     0.00%          12                12     0.00%         104               104     0.00%          40                40     0.00%
Mpp/MPPTunnelSet.h                       4                 4     0.00%           4                 4     0.00%           6                 6     0.00%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 1038               760    26.78%         150                80    46.67%        1479               947    35.97%         752               502    33.24%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18309      9649             47.30%    205483  96629        52.97%

full coverage report (for internal network access only)

dbms/src/Flash/Coprocessor/DAGContext.h

dbms/src/Flash/Coprocessor/DAGUtils.cpp

dbms/src/Flash/Coprocessor/DAGUtils.h

dbms/src/Flash/Mpp/MPPTask.cpp

dbms/src/Flash/Mpp/MPPTunnelSet.cpp

Signed-off-by: xufei <[email protected]>

dbms/src/Flash/Coprocessor/DAGContext.cpp

bestwoody

lgtm

yibin87

LGTM

dbms/src/Flash/Mpp/MPPTask.cpp

Co-authored-by: SeaRise <[email protected]>

windtalker · 2022-06-14T08:41:38Z

/merge

ti-chi-bot · 2022-06-14T08:41:39Z

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-06-14T08:41:41Z

This pull request has been accepted and is ready to merge.

Commit hash: 9118dc2

sre-bot · 2022-06-14T09:17:42Z

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGContext.cpp             100                64    36.00%          24                11    54.17%         173               107    38.15%          68                52    23.53%
Flash/Coprocessor/DAGContext.h                40                14    65.00%          31                12    61.29%          88                34    61.36%          12                 6    50.00%
Flash/Coprocessor/DAGUtils.cpp               347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Flash/Coprocessor/InterpreterDAG.cpp          16                 4    75.00%           5                 0   100.00%          50                 5    90.00%          10                 3    70.00%
Flash/Mpp/MPPTask.cpp                        453               453     0.00%          24                24     0.00%         394               394     0.00%         200               200     0.00%
Flash/Mpp/MPPTask.h                            3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Flash/Mpp/MPPTunnelSet.cpp                    63                63     0.00%          12                12     0.00%         104               104     0.00%          40                40     0.00%
Flash/Mpp/MPPTunnelSet.h                       4                 4     0.00%           4                 4     0.00%           6                 6     0.00%           0                 0         -
Interpreters/Context.cpp                     531               330    37.85%         167                88    47.31%        1147               700    38.97%         290               214    26.21%
Interpreters/Context.h                        13                 5    61.54%          13                 5    61.54%          13                 5    61.54%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       1570              1095    30.25%         328               174    46.95%        2616              1652    36.85%        1032               712    31.01%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18325      9653             47.32%    205783  96646        53.03%

full coverage report (for internal network access only)

windtalker added 2 commits June 13, 2022 13:26

move exchange_receiver_map from dag_context to mpptask

813d9bd

Signed-off-by: xufei <[email protected]>

refine

1bc03a7

Signed-off-by: xufei <[email protected]>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 13, 2022

windtalker requested a review from SeaRise June 13, 2022 05:54

ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2022

windtalker requested review from bestwoody, SeaRise and yibin87 and removed request for SeaRise June 13, 2022 05:55

SeaRise reviewed Jun 13, 2022

View reviewed changes

address comments

ea8414b

Signed-off-by: xufei <[email protected]>

bestwoody reviewed Jun 14, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/DAGContext.cpp Show resolved Hide resolved

bestwoody approved these changes Jun 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 14, 2022

yibin87 approved these changes Jun 14, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 14, 2022

SeaRise reviewed Jun 14, 2022

View reviewed changes

dbms/src/Flash/Mpp/MPPTask.cpp Outdated Show resolved Hide resolved

dbms/src/Flash/Mpp/MPPTask.cpp Show resolved Hide resolved

Update dbms/src/Flash/Mpp/MPPTask.cpp

9118dc2

Co-authored-by: SeaRise <[email protected]>

SeaRise approved these changes Jun 14, 2022

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2022

Merge branch 'master' into refine_exchange_receiver_map

60d7249

ti-chi-bot merged commit 864cfe9 into pingcap:master Jun 14, 2022

windtalker deleted the refine_exchange_receiver_map branch June 14, 2022 09:22

windtalker mentioned this pull request Aug 18, 2022

Fix data race in tunnel_set/receiver_set and establish call data #5650

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 18, 2022

Fix data race in tunnel_set/receiver_set and establish call data (#5650) #5652

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some refinements of `mpp_exchange_receiver_map` and `MPPTunnelSet` #5132

Some refinements of `mpp_exchange_receiver_map` and `MPPTunnelSet` #5132

windtalker commented Jun 13, 2022

ti-chi-bot commented Jun 13, 2022 •

edited

Loading

windtalker commented Jun 13, 2022

sre-bot commented Jun 13, 2022

bestwoody left a comment

yibin87 left a comment

windtalker commented Jun 14, 2022

ti-chi-bot commented Jun 14, 2022

ti-chi-bot commented Jun 14, 2022

sre-bot commented Jun 14, 2022

Some refinements of mpp_exchange_receiver_map and MPPTunnelSet #5132

Some refinements of mpp_exchange_receiver_map and MPPTunnelSet #5132

Conversation

windtalker commented Jun 13, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jun 13, 2022 • edited Loading

windtalker commented Jun 13, 2022

sre-bot commented Jun 13, 2022

Coverage for changed files

Coverage summary

bestwoody left a comment

Choose a reason for hiding this comment

yibin87 left a comment

Choose a reason for hiding this comment

windtalker commented Jun 14, 2022

ti-chi-bot commented Jun 14, 2022

ti-chi-bot commented Jun 14, 2022

sre-bot commented Jun 14, 2022

Coverage for changed files

Coverage summary

Some refinements of `mpp_exchange_receiver_map` and `MPPTunnelSet` #5132

Some refinements of `mpp_exchange_receiver_map` and `MPPTunnelSet` #5132

ti-chi-bot commented Jun 13, 2022 •

edited

Loading