Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: add new module schema #4932

Merged
merged 19 commits into from
May 30, 2022
Merged

Refactor: add new module schema #4932

merged 19 commits into from
May 30, 2022

Conversation

hzh0425
Copy link
Contributor

@hzh0425 hzh0425 commented May 19, 2022 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #4646

Problem Summary: refactor the module -- dbms/src/storage/transaction, add a new module -- schema

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2022
fuzhe1989
fuzhe1989 reviewed May 19, 2022
View reviewed changes
dbms/CMakeLists.txt Outdated Show resolved Hide resolved
@hzh0425
Copy link
Contributor Author

hzh0425 commented May 19, 2022

/cc @JaySon-Huang

@ti-chi-bot ti-chi-bot requested a review from JaySon-Huang May 19, 2022 07:39
@JaySon-Huang JaySon-Huang mentioned this pull request May 20, 2022
Closed
12 tasks
@ywqzzy ywqzzy changed the title feat: add new module schema Refactor: add new module schema May 24, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2022
@hzh0425
Copy link
Contributor Author

hzh0425 commented May 24, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 24, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18222      9784             46.31%    204130  97959        52.01%

full coverage report (for internal network access only)

@hzh0425
Copy link
Contributor Author

hzh0425 commented May 25, 2022

/cc @JaySon-Huang

JaySon-Huang
JaySon-Huang reviewed May 25, 2022
View reviewed changes
dbms/src/Storages/Transaction/TMTContext.cpp Outdated
Comment on lines 58 to 59
, wait_index_timeout_ms(0)
, read_index_worker_tick_ms(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, wait_index_timeout_ms(0)
, read_index_worker_tick_ms(0)
, wait_index_timeout_ms(DEFAULT_WAIT_INDEX_TIMEOUT_MS)
, read_index_worker_tick_ms(10)

JaySon-Huang
JaySon-Huang reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@JaySon-Huang
Copy link
Contributor

/cc @CalvinNeo

@ti-chi-bot ti-chi-bot requested a review from CalvinNeo May 25, 2022 11:00
JaySon-Huang
JaySon-Huang approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 25, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
Lloyd-Pottiger
Lloyd-Pottiger approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2022
@Lloyd-Pottiger
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0161857

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2022
@ti-chi-bot
Copy link
Member

@hzh0425: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 30, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18291      9796             46.44%    204931  98220        52.07%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 516fa15 into pingcap:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 left review comments

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hzh0425 @ti-chi-bot @sre-bot @JaySon-Huang @Lloyd-Pottiger @fuzhe1989