Fix an invalid default value cause bootstrap failed

[Lloyd-Pottiger]

What problem does this PR solve?

Issue Number: close #3157

Problem Summary:

What is changed and how it works?

when value is 0.0, value.convert<Int64>(); raise a error.
Convert it to String first, and convert String to Int64 by std::stoull
static_cast<Int64>(std::stoull(value.convert<String>()));

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Lloyd-Pottiger]

mysql test> create table t (a int);
-- The type of column i is int, but the default value is set to "0.00"
mysql test> alter table t add column i int not null default 0.00; 
mysql test> alter tablet t set tiflash replica 1;
mysql test> select a from t;

[Lloyd-Pottiger]

mysql> use test
Database changed
mysql> create table t (a int default 0.0);
Query OK, 0 rows affected (0.07 sec)

mysql> ALTER TABLE t SET TIFLASH REPLICA 1;
Query OK, 0 rows affected (0.07 sec)

mysql> show create table t;
+-------+------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                               |
+-------+------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `a` int(11) DEFAULT '0.0'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
+-------+------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.01 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
+------+
1 row in set (0.25 sec)

mysql> alter table t change a a int default 1.25;
Query OK, 0 rows affected (0.06 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.00 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
|    1 |
+------+
2 rows in set (0.02 sec)

mysql> alter table t change a a int default 2.8;
Query OK, 0 rows affected (0.06 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.01 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
|    1 |
|    3 |
+------+
3 rows in set (0.02 sec)

[Lloyd-Pottiger]

/run-all-tests

[Lloyd-Pottiger]

/rebuild

[sre-bot]

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18154      9788             46.08%    202642  97933        51.67%

full coverage report (for internal network access only)

[JaySon-Huang]

LGTM

[Lloyd-Pottiger]

/merge

[sre-bot]

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18277      9785             46.46%    204804  98125        52.09%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5025.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5026.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5330.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5331.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5332.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5333.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5334.