Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NULL behavior fix for logical operator #380

Merged
merged 11 commits into from
Jan 7, 2020
Merged

NULL behavior fix for logical operator #380

merged 11 commits into from
Jan 7, 2020

Conversation

windtalker
Copy link
Contributor

TiDB and TiFlash have different NULL behavior for some logical operator(https://docs.google.com/document/d/17y5CTZ3cs-kmL7vg3gAYI2b8z1_B1sLh4QC9ewyFyDk/edit)
This pr add tidbAnd and tidbOr in TiFlash, and coprocessor will use these functions instead of ch native logical functions

@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

@zanmato1984
Copy link
Contributor

Why don't we just fix ClickHouse and/or if we are sure that they are against the standard SQL.

@windtalker
Copy link
Contributor Author

Why don't we just fix ClickHouse and/or if we are sure that they are against the standard SQL.

the main concern is it will make TiFlash incompatible with ClickHouse

@zanmato1984
Copy link
Contributor

Why don't we just fix ClickHouse and/or if we are sure that they are against the standard SQL.

the main concern is it will make TiFlash incompatible with ClickHouse

What's the point of keeping TiFlash being compatible with ClickHouse?

@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker
Copy link
Contributor Author

Why don't we just fix ClickHouse and/or if we are sure that they are against the standard SQL.

the main concern is it will make TiFlash incompatible with ClickHouse

What's the point of keeping TiFlash being compatible with ClickHouse?

remove tidbAnd/tidbOr, fix ClickHouse and/or inplace.

zanmato1984
zanmato1984 reviewed Jan 3, 2020
View reviewed changes
dbms/src/Functions/FunctionsLogical.h Outdated
return !is_null && !value;
}

static void adjustForNullValue(UInt8 & value, UInt8 & is_null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not inline this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@windtalker
Copy link
Contributor Author

/rebuild

@windtalker
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker
Copy link
Contributor Author

/rebuild

@windtalker
Copy link
Contributor Author

/run-integration-tests

zanmato1984
zanmato1984 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker windtalker merged commit d72ddee into pingcap:master Jan 7, 2020
@windtalker windtalker deleted the logical_op branch January 7, 2020 04:23
This was referenced Sep 4, 2024
Closed
Merged
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@windtalker @zanmato1984