Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid YEAR string is not compatible with Mysql #9856

Merged
merged 7 commits into from
Mar 25, 2019
Merged

fix invalid YEAR string is not compatible with Mysql #9856

merged 7 commits into from
Mar 25, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 22, 2019

What problem does this PR solve?

Fix the problem invalid YEAR string is not compatible with Mysql

fix #9767

What is changed and how it works?

modify year adjust rule compatible with Mysql

Check List

Tests

  • Unit test
  • Integration test

@qw4990 qw4990 mentioned this pull request Mar 23, 2019
Closed
30 tasks
@codecov
Copy link

codecov bot commented Mar 24, 2019 •
edited
Loading

Codecov Report

Merging #9856 into master will decrease coverage by 9.8517%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9856        +/-   ##
================================================
- Coverage   77.2104%   67.3587%   -9.8518%     
================================================
  Files           405        383        -22     
  Lines         81634      80438      -1196     
================================================
- Hits          63030      54182      -8848     
- Misses        13933      21415      +7482     
- Partials       4671       4841       +170

@zz-jason zz-jason added contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. component/expression labels Mar 25, 2019
zz-jason
zz-jason reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2019
@zz-jason zz-jason requested review from qw4990 and XuHuaiyu March 25, 2019 05:57
@lzmhhh123
Copy link
Contributor

LGTM.

@lzmhhh123
Copy link
Contributor

/run-all-tests

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2019
@lzmhhh123 lzmhhh123 merged commit 5025d58 into pingcap:master Mar 25, 2019
qw4990 pushed a commit to qw4990/tidb that referenced this pull request May 15, 2019
@b41sh @qw4990
fix invalid YEAR string is not compatible with Mysql (pingcap#9856)
e56d16d
@qw4990 qw4990 mentioned this pull request May 15, 2019
Merged
@b41sh b41sh deleted the fix-invalid-YEAR-issue branch June 19, 2019 11:48
@cyliu0 cyliu0 mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling invalid YEAR string is not compatible with Mysql
3 participants
@b41sh @lzmhhh123 @zz-jason