executor: only show valid columns in stats_histogram
#9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9487 +/- ##
==========================================
- Coverage 67.42% 67.41% -0.02%
==========================================
Files 373 373
Lines 78568 78570 +2
==========================================
- Hits 52976 52965 -11
- Misses 20837 20845 +8
- Partials 4755 4760 +5
Continue to review full report at Codecov.
|
zz-jason
requested review from
alivxxx and
winoros
and removed request for
alivxxx
winoros
reviewed
Feb 27, 2019
| @@ -82,6 +82,9 @@ func (e *ShowExec) appendTableForStatsHistograms(dbName, tblName, partitionName | |||
| return | |||
| } | |||
| for _, col := range statsTbl.Columns { | |||
| if col.IsInvalid(nil, false) { | |||
There was a problem hiding this comment.
Do we need to mark column stats needed in show stats_histograms?
There was a problem hiding this comment.
how about adding a comment like "pass a nil StatementContext to avoid column stats being marked as needed"?
There was a problem hiding this comment.
Comment added, PTAL
zz-jason
added
status/LGT2
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Feb 28, 2019
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Feb 28, 2019
zz-jason
pushed a commit
that referenced
this pull request
Feb 28, 2019
zz-jason
pushed a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9479
What is changed and how it works?
Check if the column is valid or loaded before appending it to result of
show stats_histograms.Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes