-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan: rewrite exact like
expression to equal condition
#9071
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9071 +/- ##
==========================================
+ Coverage 67.19% 67.21% +0.01%
==========================================
Files 371 371
Lines 76958 76982 +24
==========================================
+ Hits 51711 51742 +31
+ Misses 20624 20618 -6
+ Partials 4623 4622 -1
Continue to review full report at Codecov.
|
like
expression to equal condition
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you just need to check whether er.ctxStack[l-1]
is a string without regex pattern.
@winoros when pattern string contains escape character , we should use the compiled result of the pattern string in the equal condition, eg: |
We need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any specific reason? |
@hhxcc @eurekaka
The second time it use the physical plan cached by the first time then return wrong result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for your contribution!
/run-all-tests |
What problem does this PR solve?
Fix #8962
What is changed and how it works?
rewrite such kind of like function to equal function.
Check List
Tests
Related changes