types: support sql_mode ALLOW_INVALID_DATES #9027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobotu
force-pushed
the
allow-invalid-dates
branch
from
430756a to
3af1c03
Compare
bobotu
force-pushed
the
allow-invalid-dates
branch
from
3af1c03 to
3259a81
Compare
jackysp
reviewed
Jan 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #9027 +/- ##
==========================================
- Coverage 67.26% 67.26% -0.01%
==========================================
Files 371 371
Lines 76000 76009 +9
==========================================
+ Hits 51123 51128 +5
- Misses 20365 20367 +2
- Partials 4512 4514 +2
Continue to review full report at Codecov.
|
imtbkcat
reviewed
Jan 14, 2019
| runWithMode := func(mode string) { | ||
| inputs := []string{"0000-00-00", "2019-00-00", "2019-01-00", "2019-00-01", "2019-02-31"} | ||
| results := testkit.Rows(`0 0 0`, `2019 0 0`, `2019 1 0`, `2019 0 1`, `2019 2 31`) | ||
|
|
There was a problem hiding this comment.
Maybe we should set the original sql_mode back after finishing this test, using defer in line 250.
|
PTAL @imtbkcat |
|
/run-all-tests |
morgo
added a commit
to pingcap/docs
that referenced
this pull request
Jan 15, 2019
bobotu
added a commit
to bobotu/tidb
that referenced
this pull request
Jan 18, 2019
ngaut
pushed a commit
that referenced
this pull request
Jan 20, 2019
CaitinChen
pushed a commit
to pingcap/docs
that referenced
this pull request
Jan 28, 2019
* sql: allow_invalid_dates is now supported via pingcap/tidb#9027 * Address PR Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support mode
ALLOW_INVALID_DATES(fix #8263). With this mode enabled it will not perform full checking of dates. Check only that the month is in the range from 1 to 12 and the day is in the range from 1 to 31 (also allow zero values such as0000-00-00).What is changed and how it works?
Add a new flag
AllowInvalidDateintoStatementContext. ThencheckMonthDaycheck the month and day according to this flag.Check List
Tests
Code changes