Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support altering the other charset to utf8 or utf8mb4 (#8037) #8951

Merged
merged 3 commits into from
Jan 7, 2019
Merged

ddl: support altering the other charset to utf8 or utf8mb4 (#8037) #8951

merged 3 commits into from
Jan 7, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jan 5, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick #8037 ,
Please merge pingcap/parser#152 first.

CREATE TABLE tt (
a varchar(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL DEFAULT ''
) CHARACTER SET = utf8 COLLATE = utf8_general_ci;

INSERT INTO tt VALUES ('🕶小楠～');  // return error.

// before this PR, release 2.1 can not support change column charset.
alter table tt modify column a varchar(64) CHARACTER SET utf8mb4;

What is changed and how it works?

Check List

Tests

This change is Reviewable

@crazycs520 crazycs520 mentioned this pull request Jan 5, 2019
Merged
jackysp
jackysp reviewed Jan 5, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2019

@crazycs520 Please add some proper labels. For example, component, type.

zz-jason
zz-jason previously approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2019

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 5, 2019
winkyao
winkyao previously approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crazycs520 crazycs520 dismissed stale reviews from winkyao and zz-jason via 082007d January 7, 2019 03:55
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=pr/713 pd=release-2.1 tikv=release-2.1

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=pr/713 pd=release-2.1 tikv=release-2.1

@jackysp jackysp merged commit 665db64 into pingcap:release-2.1 Jan 7, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@winkyao winkyao winkyao left review comments

@zz-jason zz-jason zz-jason left review comments

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @zz-jason @jackysp @winkyao @you06