Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression,util/encrypt: add support for AES OFB mode #8605

Merged
merged 15 commits into from
Jan 11, 2019

Conversation

snithish
Copy link
Contributor

@snithish snithish commented Dec 6, 2018

What problem does this PR solve?

This PR solves part #7490 (add more modes for AES)

What is changed and how it works?

I have included implementation for aes-128-ofb, aes-192-ofb, aes-256-ofb

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Exported AESDecryptWithOFB and AESEncryptWithOFB functions

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2018

CLA assistant check
All committers have signed the CLA.

@zz-jason zz-jason added contribution This PR is from a community contributor. component/expression labels Dec 6, 2018
@zhouqiang-cl
Copy link
Contributor

/rebuild

@zz-jason
Copy link
Member

zz-jason commented Jan 2, 2019

@snithish Thanks for your contribution, I'm sorry for the late review. The main change looks fine to me. Could you merge the latest master branch and resolve the code conflicts so that we can continue to review and get this PR merged as early as possible?

@snithish
Copy link
Contributor Author

snithish commented Jan 3, 2019

@zz-jason Sure I will work on that over the weekend and have it ready for a review

@snithish
Copy link
Contributor Author

snithish commented Jan 4, 2019

@zz-jason I have merged the latest master and resolved the conflicts. Let me know your thoughts.

@mccxj mccxj mentioned this pull request Jan 4, 2019
18 tasks
@codecov-io
Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #8605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8605      +/-   ##
==========================================
+ Coverage   67.57%   67.58%   +<.01%     
==========================================
  Files         364      364              
  Lines       75421    75441      +20     
==========================================
+ Hits        50969    50987      +18     
- Misses      19957    19960       +3     
+ Partials     4495     4494       -1
Impacted Files Coverage Δ
util/encrypt/aes.go 92.36% <100%> (+1.06%) ⬆️
expression/builtin_encryption.go 76.66% <100%> (+0.22%) ⬆️
ddl/delete_range.go 74.28% <0%> (-4.58%) ⬇️
executor/executor.go 66.8% <0%> (+0.14%) ⬆️
executor/join.go 78.96% <0%> (+0.51%) ⬆️
expression/schema.go 94.95% <0%> (+0.84%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b552bf8...17b63d0. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 5, 2019
@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2019

/run-all-tests

@zz-jason zz-jason requested review from XuHuaiyu and qw4990 January 5, 2019 13:55
@XuHuaiyu XuHuaiyu changed the title expression,util/encrypt: Add support for AES OFB mode expression,util/encrypt: add support for AES OFB mode Jan 7, 2019
util/encrypt/aes_test.go Outdated Show resolved Hide resolved
expression/integration_test.go Outdated Show resolved Hide resolved
expression/integration_test.go Show resolved Hide resolved
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 10, 2019
@XuHuaiyu XuHuaiyu removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2019
@XuHuaiyu XuHuaiyu merged commit 786a9d5 into pingcap:master Jan 11, 2019
@snithish snithish deleted the aes-ofb branch March 19, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants