-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression,util/encrypt: add support for AES OFB mode #8605
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
/rebuild |
@snithish Thanks for your contribution, I'm sorry for the late review. The main change looks fine to me. Could you merge the latest master branch and resolve the code conflicts so that we can continue to review and get this PR merged as early as possible? |
@zz-jason Sure I will work on that over the weekend and have it ready for a review |
@zz-jason I have merged the latest master and resolved the conflicts. Let me know your thoughts. |
Codecov Report
@@ Coverage Diff @@
## master #8605 +/- ##
==========================================
+ Coverage 67.57% 67.58% +<.01%
==========================================
Files 364 364
Lines 75421 75441 +20
==========================================
+ Hits 50969 50987 +18
- Misses 19957 19960 +3
+ Partials 4495 4494 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
What problem does this PR solve?
This PR solves part #7490 (add more modes for AES)
What is changed and how it works?
I have included implementation for aes-128-ofb, aes-192-ofb, aes-256-ofb
Check List
Tests
Code changes
AESDecryptWithOFB
andAESEncryptWithOFB
functionsThis change is