Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix expression rewriter wrong compare logic (#8269) #8289

Merged
merged 1 commit into from
Nov 13, 2018
Merged

planner: fix expression rewriter wrong compare logic (#8269) #8289

merged 1 commit into from
Nov 13, 2018

Conversation

imtbkcat
Copy link

cherry-pick #8269 to release 2.1

@imtbkcat imtbkcat added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Nov 13, 2018
@imtbkcat imtbkcat requested review from XuHuaiyu and winoros November 13, 2018 05:33
XuHuaiyu
XuHuaiyu reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2018
eurekaka
eurekaka approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2018
@imtbkcat
Copy link
Author

/run-all-tests pd=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@jackysp jackysp merged commit 67b37c5 into pingcap:release-2.1 Nov 13, 2018
@imtbkcat imtbkcat deleted the rcmpcherrypick21 branch November 13, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@eurekaka eurekaka eurekaka approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @eurekaka @XuHuaiyu @jackysp