Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topsql: compress plan instead of dropping it #35973

Merged
merged 6 commits into from
Jul 6, 2022
Merged

topsql: compress plan instead of dropping it #35973

merged 6 commits into from
Jul 6, 2022

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jul 6, 2022

What problem does this PR solve?

Issue Number: ref #35964

Problem Summary:

Big plans are dropped

What is changed and how it works?

  • Tag a plan whether it's large
  • Compress the plan if it's large, or else decode it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • mornyx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022
@zhongzc zhongzc force-pushed the topsql-compress branch from bdd7b0b to 01df0ab Compare July 6, 2022 03:09
@zhongzc
Copy link
Contributor Author

zhongzc commented Jul 6, 2022

/cc @mornyx @crazycs520

@ti-chi-bot ti-chi-bot requested review from crazycs520 and mornyx July 6, 2022 03:11
@zhongzc
Copy link
Contributor Author

zhongzc commented Jul 6, 2022

/rebuild

@zhongzc
Copy link
Contributor Author

zhongzc commented Jul 6, 2022

cc @hawkingrei, the build failed but I can't figure out what's going on.

@mornyx
Copy link
Contributor

mornyx commented Jul 6, 2022

LGTM

@hawkingrei
Copy link
Member

cc @hawkingrei, the build failed but I can't figure out what's going on.

You need to run gazelle to sync gomod to the bazel.

zhongzc added 2 commits July 6, 2022 14:30
@zhongzc
fix bazel
6f598b3 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
fix bazel
bcf32c9 
Signed-off-by: Zhenchi <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bcf32c9617bf61ebbac4fbd3a9750265c9989266

@zhongzc
Copy link
Contributor Author

zhongzc commented Jul 6, 2022

You need to run gazelle to sync gomod to the bazel.

I couldn't find the guide from somewhere. Did I miss something?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2022
@hawkingrei
Copy link
Member

You need to run gazelle to sync gomod to the bazel.

I couldn't find the guide from somewhere. Did I miss something?

I can add this guide to our development guide.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bcf32c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit ec9f201 into pingcap:master Jul 6, 2022
@zhongzc zhongzc deleted the topsql-compress branch July 6, 2022 08:03
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 2, success 33, total 35 24 min New failing
idc-jenkins-ci-tidb/common-test 🟥 failed 2, success 10, total 12 12 min New failing
idc-jenkins-ci-tidb/tics-test ✅ all 1 tests passed 6 min 58 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 58 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 44 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mornyx mornyx mornyx approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongzc @ti-chi-bot @mornyx @hawkingrei @sre-bot @crazycs520