txn: rename snapshot related methods in txnManager. #35912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpadeA-Tang <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
lcwangchao
approved these changes
Jul 4, 2022
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/acaa070a4e6cf46e228f5c633b3366607dabaff1 |
youjiali1995
reviewed
Jul 4, 2022
sessiontxn/interface.go
Outdated
| GetReadSnapshot() (kv.Snapshot, error) | ||
| // GetForUpdateSnapshot get snapshot with for update ts | ||
| GetForUpdateSnapshot() (kv.Snapshot, error) | ||
| // GetSnapshotWithStmtReadTS get snapshot with read ts |
There was a problem hiding this comment.
Suggested change
| // GetSnapshotWithStmtReadTS get snapshot with read ts | |
| // GetSnapshotWithStmtReadTS gets snapshot with read ts |
sessiontxn/interface.go
Outdated
| GetForUpdateSnapshot() (kv.Snapshot, error) | ||
| // GetSnapshotWithStmtReadTS get snapshot with read ts | ||
| GetSnapshotWithStmtReadTS() (kv.Snapshot, error) | ||
| // GetSnapshotWithStmtForUpdateTS get snapshot with for update ts |
There was a problem hiding this comment.
Suggested change
| // GetSnapshotWithStmtForUpdateTS get snapshot with for update ts | |
| // GetSnapshotWithStmtForUpdateTS gets snapshot with for update ts |
session/txnmanager.go
Outdated
| @@ -94,14 +94,16 @@ func (m *txnManager) GetStmtForUpdateTS() (uint64, error) { | |||
| return ts, nil | |||
| } | |||
|
|
|||
| func (m *txnManager) GetReadSnapshot() (kv.Snapshot, error) { | |||
| // GetSnapshotWithStmtReadTS get snapshot with read ts | |||
There was a problem hiding this comment.
Suggested change
| // GetSnapshotWithStmtReadTS get snapshot with read ts | |
| // GetSnapshotWithStmtReadTS gets snapshot with read ts |
session/txnmanager.go
Outdated
| if m.ctxProvider == nil { | ||
| return nil, errors.New("context provider not set") | ||
| } | ||
| return m.ctxProvider.GetSnapshotWithStmtReadTS() | ||
| } | ||
|
|
||
| func (m *txnManager) GetForUpdateSnapshot() (kv.Snapshot, error) { | ||
| // GetSnapshotWithStmtForUpdateTS get snapshot with for update ts |
There was a problem hiding this comment.
Suggested change
| // GetSnapshotWithStmtForUpdateTS get snapshot with for update ts | |
| // GetSnapshotWithStmtForUpdateTS gets snapshot with for update ts |
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
youjiali1995
approved these changes
Jul 4, 2022
ti-chi-bot
added
status/LGT2
|
/run-mysql-test |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 996897d
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
/run-check_dev_2 |
1 similar comment
|
/run-check_dev_2 |
|
/run-unit-test |
|
/run-mysql-test |
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
morgo
added a commit
to morgo/tidb
that referenced
this pull request
Jul 6, 2022
* upstream/master: (77 commits) infoschema: add a simply store for DM's SchemaTracker (pingcap#35954) planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890) telemetry: Initialize telemetry asynchronously (pingcap#35898) sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733) session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659) *: add telemetry support for multi-schema change (pingcap#35977) topsql: compress plan instead of dropping it (pingcap#35973) *: use pdqsort to improve sort performance (pingcap#34404) ddl: refine GetDDLInfo function (pingcap#35969) *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943) ddl: remove `onDropIndexes` (pingcap#35960) ddl: refine history job code (pingcap#35967) sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256) *: change remote cache (pingcap#35968) *: enable gosec (pingcap#35873) plancodec: fix a miss case in conversion (pingcap#35957) ddl: support drop indexes for multi-schema change (pingcap#35883) pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949) br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147) txn: rename snapshot related methods in txnManager. (pingcap#35912) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SpadeA-Tang [email protected]
What problem does this PR solve?
Issue Number: close #35915
Problem Summary:
What is changed and how it works?
Rename
GetReadSnapshottoGetSnapshotWithStmtReadTSandGetForUpdateSnapshottoGetSnapshotWithStmtForUpdateTSintxnManager.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.